Repository navigation
Use JFace tree path breadcrumb in Debug UI - #3061
Open
LukasHackl2 wants to merge 1 commit into
Open
LukasHackl2 wants to merge 1 commit into
LukasHackl2 wants to merge 1 commit into
Conversation
Contributor
|
I assume that of course the build cannot work until the upstream platform.ui change is merged. I can try to pull both into my workspace... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the Debug UI breadcrumb implementation to use the reusable tree path breadcrumb API introduced in eclipse-platform/eclipse.platform.ui#4496.
The existing Debug UI breadcrumb implementation duplicated much of the generic breadcrumb viewer logic. With the new JFace implementation available, this PR:
TreePathBreadcrumbViewerTreePathBreadcrumbDropDownSiteAbstractBreadcrumb,TreeViewerDropDown, andLaunchViewBreadcrumbThe Debug breadcrumb was tested at runtime after the migration and behaved as expected.
Depends on: eclipse-platform/eclipse.platform.ui#4496