Skip to content

fix: use the proof purpose authentication for LDP presentations #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paullatzelsperger merged 1 commit into from
Oct 29, 2026
Merged

fix: use the proof purpose authentication for LDP presentations #1252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...identityhub/core/services/verifiablepresentation/generators/LdpPresentationGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public class LdpPresentationGenerator implements PresentationGenerator<JsonObjec

public static final String TYPE_ADDITIONAL_DATA = "types";
public static final String HOLDER_PROPERTY = "holder";
public static final URI ASSERTION_METHOD = URI.create("https://w3id.org/security#assertionMethod");
public static final URI AUTHENTICATION = URI.create("https://w3id.org/security#authentication");
public static final URI JSON_WEB_KEY_2020 = URI.create("https://w3id.org/security#JsonWebKey2020");
private final PrivateKeyResolver privateKeyResolver;
private final SignatureSuiteRegistry signatureSuiteRegistry;
Expand Down Expand Up @@ -193,7 +193,7 @@ private JsonObject signPresentation(JsonObject presentationObject, SignatureSuit

var now = clock.instant();
var proofDraft = Jws2020ProofDraft.Builder.newInstance()
.proofPurpose(ASSERTION_METHOD)
.proofPurpose(AUTHENTICATION)
.verificationMethod(new JsonWebKeyPair(keyIdUri, JSON_WEB_KEY_2020, controllerUri, null))
.created(now)
.expires(now.plus(vpLifetime))
Expand Down
8 changes: 8 additions & 0 deletions ...tityhub/core/services/verifiablepresentation/generators/LdpPresentationGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,14 @@ public boolean isAccepted(URI id) {
assertThat(verifier.verify(presentation.toString(), VerifierContext.Builder.newInstance().verifier(verifier).build())).isSucceeded();
}

@Test
void createPresentation_proofPurposeIsAuthentication() {
var result = creator.generatePresentation(participantContextId, List.of(), PRIVATE_KEY_ALIAS, PUBLIC_KEY_ID, issuerId, ADDITIONAL_DATA);

var purpose = proof(result).getJsonArray(SECURITY_VOCAB + "proofPurpose").getJsonObject(0);
assertThat(purpose.getString("@id")).isEqualTo(SECURITY_VOCAB + "authentication");
}

@Test
void createPresentation_proofHasNoChallenge() {
var result = creator.generatePresentation(participantContextId, List.of(), PRIVATE_KEY_ALIAS, PUBLIC_KEY_ID, issuerId, ADDITIONAL_DATA);
Expand Down
Loading