Repository navigation
fix: use the proof purpose authentication for LDP presentations - #1252
Merged
paullatzelsperger merged 1 commit intoOct 29, 2026
Conversation
VC Data Integrity defines authentication as the purpose of presentation proofs, and presentation signing keys are published under authentication in the holder's DID document. EDC verifiers accept it since eclipse-edc/Connector#6156. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
paullatzelsperger
added
bug
jimmarino
approved these changes
Oct 29, 2026
paullatzelsperger
deleted the
fix/1251_ldp_presentation_authentication
branch
October 29, 2026 12:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
LdpPresentationGeneratorcreates presentation proofs with the purposeauthenticationinstead ofassertionMethod.LdpPresentationGeneratorTestchecks the purpose, and the existing test that verifies a generated presentation with the EDCLdpVerifiernow runs against a verifier that acceptsauthentication.Why it does that
VC Data Integrity defines
authenticationas the purpose of presentation proofs, and since #1246 presentation signing keys are published underauthenticationin the holder's DID document. EDC verifiers accept the purpose since eclipse-edc/Connector#6156.Breaking change for counterparties: EDC verifiers older than the Connector release that includes eclipse-edc/Connector#6156 reject Linked-Data presentations from this version.
Linked Issue(s)
Closes #1251
🤖 Generated with Claude Code