Repository navigation
fix: publish DID document keys only under the relationships of their usages - #1246
Merged
paullatzelsperger merged 2 commits intoOct 23, 2026
Merged
paullatzelsperger merged 2 commits into
paullatzelsperger merged 2 commits into
Conversation
paullatzelsperger
added
bug
paullatzelsperger
force-pushed
the
fix/did_key_relationships
branch
from
October 23, 2026 11:35
bc5baf9 to
aa22f79
Compare
…usages A key pair is added to the verification relationships of its usages only: credential signing keys to assertionMethod, presentation signing keys to authentication and token signing keys to capabilityInvocation. Activating a key pair again replaces its earlier relationships, and revoking it removes it from all of them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
paullatzelsperger
force-pushed
the
fix/did_key_relationships
branch
from
October 23, 2026 11:41
aa22f79 to
73c7e33
Compare
wolf4ood
approved these changes
Oct 23, 2026
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
DidDocumentServiceImpladds an activated key pair only to the verification relationships of its usages:sign_credentialstoassertionMethod,sign_presentationtoauthenticationandsign_tokentocapabilityInvocation. A key pair with several usages, such as the default one with all usages, is added to several relationships.assertionMethodas well.DidDocumentServiceImplTestcovers each usage, a key pair with all usages, re-activation and revocation.Why it does that
Every key pair was added to
authenticationandcapabilityInvocation, whatever its usage, and none toassertionMethod. Verifiers that follow VC Data Integrity or the Controlled Identifiers spec look for credential signing keys underassertionMethod, so they rejected IssuerService credentials. The usages of a key pair were also not reflected in the DID document: a credential signing key was offered for authentication and token signing.Existing DID documents get
assertionMethodwhen their key pairs are activated again. Requires eclipse-edc/Connector#6153, which addsassertionMethodtoDidDocument.Linked Issue(s)
none
🤖 Generated with Claude Code