Skip to content

CHG: Only set EnergyCalibrationError for TRIGGERED strips without energy calibration - #287

Open
julianmgerber wants to merge 3 commits into
cositools:develop/emfrom
julianmgerber:EcalModuleFix
Open

julianmgerber wants to merge 3 commits into
cositools:develop/emfrom
julianmgerber:EcalModuleFix

Conversation

@julianmgerber

Copy link
Copy Markdown

Two changes here:

  1. Previously, in the Ecal module it was assumed that if a strip had no energy resolution fit then it also wouldn't have an energy fit. However, in the newest ecal file, I've been seeing strips that have the opposite: an energy fit but no resolution fit. I've edited the ecal module to correctly BD flag strips that have no energy resolution fit.
  2. I've also edited the Ecal module to only flag an event as "bad" in the energy calibration module if a strip is triggered. I've been seeing that when running nuclearizer with nearest neighbors, tons of events (~20%) get thrown out because a NN strip doesn't have an energy calibration. These events are still able to be calibrated though so long as all the triggered strips have calibrations. In the future, when we have an energy correction based on nearest neighbors, this should probably be a separate flag.

Comment thread src/MModuleEnergyCalibration.cxx Outdated
Comment thread src/MModuleEnergyCalibration.cxx Outdated
@fhagemann fhagemann changed the title Ecal module fix CHG: Only set EnergyCalibrationError for TRIGGERED strips without energy calibration Oct 23, 2026

@fhagemann fhagemann left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the PR, should be good to go from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants