Repository navigation
FIX: Allow poly3 energy res fits - #286
Merged
Merged
Conversation
fhagemann
approved these changes
Oct 21, 2026
fhagemann
reviewed
Oct 21, 2026
ckierans
approved these changes
Oct 21, 2026
Co-authored-by: Felix Hagemann <hagemann@berkeley.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a 3rd order polynomial could not be parsed in the energy calibration module for the energy resolution fits. Now a poly3 function can be parsed. Verified that this works for both the new (10/20/2026) ecal file that Robin made and also the old unit level ecals.