Repository navigation
CHG: Rework the TAC module to ensure the correct detectorID is used per strip hit - #239
Merged
Merged
Conversation
…rip hit. Before: TACCal files were used to determine the detectorID but now they carry dibID and were being mistaken for DetID. Now, the strip number from the TACCal file is matched to the strip number in the strip map and the detectorID is grabbed from there. If the strip map was already provided from a loader module, nothing changes for the TACcal gui. If running cosima with DEE, the Taccal file has an input for the strip map.
fhagemann
reviewed
Oct 16, 2026
fhagemann
left a comment
fhagemann
left a comment
There was a problem hiding this comment.
Before I review and run the code: how does this affect the DEE, where we also apply inverse TAC cal. Would we need a strip map here as well?
Collaborator
|
The TAC Cal files don't have a # sign in the first header line, but the current module expects this. We've had to manually add it to run the most recent taccal file. Can you also remove this requirement/expectation from the module in this PR? |
fhagemann
reviewed
Oct 17, 2026
fhagemann
changed the title
fhagemann
force-pushed
the
TAC_Strip2DetID
branch
from
October 17, 2026 17:09
3e7afbc to
cdd39d2
Compare
fhagemann
reviewed
Oct 17, 2026
fhagemann
reviewed
Oct 17, 2026
fhagemann
left a comment
fhagemann
left a comment
There was a problem hiding this comment.
Unit tests looks great again, just minor comments.
Co-authored-by: Felix Hagemann <hagemann@berkeley.edu>
|
I will look into why the tests are failing on GitHub (they pass on my laptop?) |
Merged updated upstream into local branch
Co-authored-by: Felix Hagemann <hagemann@berkeley.edu>
|
Don't tell me that the tests were failing only because we didn't merge the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: TACCal files were used to determine the detectorID but now they carry dibID and were being mistaken for DetID. Now, the strip number from the TACCal file is matched to the strip number in the strip map and the detectorID is grabbed from there. If the strip map was already provided from a loader module, nothing changes for the TACcal gui. If running cosima with DEE, the Taccal file has an input for the strip map.