Repository navigation
refactor(prompts,resources): use shared Field in args forms - #181
Merged
vishu-bh merged 1 commit intoOct 12, 2026
Merged
Conversation
marekdano
requested review from
gcgoncalves,
marekdano and
vishu-bh
and removed request for
marekdano
October 9, 2026 10:44
marekdano
reviewed
Oct 9, 2026
marekdano
left a comment
marekdano
left a comment
Contributor
There was a problem hiding this comment.
@CloudCorpRecords - thanks for contribution!!!
The PR looks good! Just one blocking issue.
DCO check is failing — the commit has no Signed-off-by: trailer. This has to be fixed before merging.
Convert PromptArgsForm and ResourceArgsForm per-argument labels to Field, dropping the hand-rolled required asterisk and sr-only text. Field supplies aria-required (true/false) and the required announcement via the shared common.field.required message, so the now-unused *.args.required locale keys are removed. Refs IBM/mcp-context-forge#7007 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Rene Turcios <95189389+CloudCorpRecords@users.noreply.github.com>
CloudCorpRecords
force-pushed
the
refactor/7007-args-forms
branch
from
October 10, 2026 03:22
9ccf0eb to
7a40d08
Compare
Contributor
Author
|
Thanks for the review, @marekdano. DCO sign-off added (amended and force-pushed), so the check is green now. |
marekdano
approved these changes
Oct 12, 2026
marekdano
left a comment
marekdano
left a comment
Contributor
There was a problem hiding this comment.
@CloudCorpRecords - thanks for addressing the DCO issue.
LGTM 🚀
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second checklist item of IBM/mcp-context-forge#7007: convert the per-argument label in
PromptArgsForm.tsxandResourceArgsForm.tsxto the sharedField, dropping the hand-rolled required asterisk / sr-only text.Fieldsuppliesid,aria-required(true/false) and the visible*plus screen-reader "required" text (from the sharedcommon.field.requiredmessage)labelPropsrequiredon the input and the placeholder behavior are unchangedprompts.details.code.args.requiredandresources.details.code.args.requiredkeys from the en-US, es-ES and pt-BR locale filesIndependent of #180 (different files), so no merge ordering needed.
Test plan
vitest run src/i18n src/components/prompts src/components/resources(226/226), including the existingPromptArgsFormassertions on accessible name andaria-requiredtrue/falseeslint/prettierclean; pre-commit secret scan passes; thenpm run buildstep of the pre-push hook passes--no-verify. The pre-push hook runs the full suite, and on my machineApp.test.tsx"logs in and navigates to Gateways page" (plus a couple of other unrelated tests) fails in full-suite runs on untouched upstreammaintoo, while passing 5/5 in isolation. CI will run the full suite on this PR.Refs IBM/mcp-context-forge#7007
🤖 Generated with Claude Code