Repository navigation
refactor(auth): use shared Field in Login, ForgotPassword and PasswordChangeRequired - #191
Open
CloudCorpRecords wants to merge 1 commit into
Open
CloudCorpRecords wants to merge 1 commit into
CloudCorpRecords wants to merge 1 commit into
Conversation
…dChangeRequired Replace the hand-built label + control (+ error) markup on the three auth pages with Field. Login keeps its existing label/control styling via labelProps and the native required attribute (no visual asterisk, as before). ForgotPassword's email error now comes from Field (aria-invalid, aria-describedby, role=alert) instead of a hand-wired id. The read-only email on PasswordChangeRequired uses Field for its label. Refs IBM/mcp-context-forge#7007 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Rene Turcios <95189389+CloudCorpRecords@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Next checklist item of IBM/mcp-context-forge#7007 (after #181): convert the auth pages' hand-built label + control markup to the shared
Field.Login.tsx: email and password useField. The existing label and input classes are kept (labelProps/ on theInput), and the nativerequiredattribute stays without a visual asterisk, as before.ForgotPassword.tsx: the email field usesField; its error now comes fromField(aria-invalid,aria-describedby,role="alert") instead of a hand-wiredforgot-password-email-errorid.PasswordChangeRequired.tsx: the read-only email field usesFieldfor its label (the three password fields already go throughPasswordInput, which wrapsField).Not touched:
ToolArgumentsForm(a larger conversion, I'll do it as its own PR) andCatalogOAuthDialog.Label-to-control spacing on these pages now follows
Field's standard gap rather than the oldmb-1/space-y-1.Test plan
tsc -bclean;eslintandprettiercleanvitest run src/pages src/components: 2745 passed (includes the existing Login / ForgotPassword / PasswordChangeRequired / App tests)--no-verify: the local pre-push hook runs the full suite, whereApp.test.tsx"logs in and navigates to Gateways page" fails on untouchedmainon my machine while passing in isolation. CI will run the full suite.Refs IBM/mcp-context-forge#7007
🤖 Generated with Claude Code