Skip to content

fix: tiernan_all_cycles requires only a vertex_index map #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Becheler merged 2 commits into from
Nov 1, 2026
Merged

fix: tiernan_all_cycles requires only a vertex_index map #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e6e456
bug: tiernan_all_cycles rejects adjacency_list
Becheler Nov 1, 2026
7844c67
fix: tiernan_all_cycles requires only a vertex_index map
Becheler Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/boost/graph/tiernan_all_cycles.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,9 @@ namespace detail
const ClosedMatrix& m)
{
BOOST_CONCEPT_ASSERT((IncidenceGraphConcept< Graph >));
BOOST_CONCEPT_ASSERT((VertexIndexGraphConcept< Graph >));
typedef typename graph_traits< Graph >::vertex_descriptor Vertex;
using IndexMap = typename ::boost::property_map< Graph, ::boost::vertex_index_t >::const_type;
BOOST_CONCEPT_ASSERT((::boost::ReadablePropertyMapConcept< IndexMap, Vertex >));

// get the vertices in question
Vertex u = source(e, g), v = target(e, g);
Expand Down
20 changes: 20 additions & 0 deletions test/tiernan_all_cycles.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#include <iostream>

#include <boost/graph/graph_utility.hpp>
#include <boost/graph/adjacency_list.hpp>
#include <boost/graph/undirected_graph.hpp>
#include <boost/graph/directed_graph.hpp>
#include <boost/graph/tiernan_all_cycles.hpp>
Expand Down Expand Up @@ -103,6 +104,24 @@ void test_stateful_visitor_with_ref()
BOOST_TEST_EQ(copied.count, static_cast< std::size_t >(0));
}

// adjacency_list has a vertex index but no renumber_vertex_indices, see issue 182
void test_adjacency_list()
{
using graph_t = boost::adjacency_list< boost::vecS, boost::vecS, boost::directedS >;
graph_t g(4);

// a triangle and a two cycle, so two elementary cycles
boost::add_edge(0, 1, g);
boost::add_edge(1, 2, g);
boost::add_edge(2, 0, g);
boost::add_edge(1, 3, g);
boost::add_edge(3, 1, g);

cycle_tally tally;
boost::tiernan_all_cycles(g, std::ref(tally));
BOOST_TEST_EQ(tally.count, static_cast< std::size_t >(2));
}

int main(int, char*[])
{
typedef undirected_graph<> Graph;
Expand All @@ -115,6 +134,7 @@ int main(int, char*[])
test< DiGraph >();

test_stateful_visitor_with_ref();
test_adjacency_list();

return boost::report_errors();
}
Loading