Repository navigation
fix: tiernan_all_cycles requires only a vertex_index map - #686
Merged
Becheler merged 2 commits intoNov 1, 2026
Merged
Conversation
|
Boost dependency footprint vs Header-inclusion weights (graph files pulling each direct dependency in): No header-inclusion-weight changes. Transitive Boost modules: 47 → 47 (0) |
Becheler
force-pushed
the
fix/issue-182-tiernan-vertex-index
branch
from
November 1, 2026 00:17
b7f5a1b to
5e6e456
Compare
|
Compiler-warning counts vs
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182
Motivation
tiernan_all_cyclesassertedVertexIndexGraphConcept, which requiresrenumber_vertex_indices(). Onlydirected_graphandundirected_graphprovide that function, so the algorithm failed to compile for every other graph type, includingadjacency_list. The algorithm never callsrenumber_vertex_indices(). It only reads vertex indices.What this PR does
Replaces the check with one that only requires a readable
vertex_indexmap, which is what the documentation already states.tiernan_all_cyclesnow compiles foradjacency_listand any other graph with avertex_indexmap. A new regression test runs the algorithm on anadjacency_listand expects two cycles.Before submitting
developbranch.Kind of change
Tick exactly one. Each kind is reviewed differently, so mixing them in one PR makes the diff difficult to review (why).
Change category