Skip to content

feat: add AWS_SMUS connector type - #1088

Merged
Aryamanz29 merged 1 commit into
mainfrom
zamanishtiyaq/add-aws-smus-connector-type
Oct 15, 2026
Merged

Aryamanz29 merged 1 commit into
mainfrom
zamanishtiyaq/add-aws-smus-connector-type

Conversation

@zaman-atlan

@zaman-atlan zaman-atlan commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

AtlanConnectorType has no entry for AWS SageMaker Unified Studio, whose connector name is aws-smus. Without it, Connection.creator(connector_type=...) can't create an SMUS connection, and scripts have to fall back to AtlanConnectorType.CREATE_CUSTOM.

This adds AWS_SMUS = ("aws-smus", AtlanConnectionCategory.SAAS) next to AWS_SAGEMAKER. The category is SaaS because that's what the Atlan UI sets on the SMUS connections it creates. atlan-publish-app also takes partial-Connection categories from this enum and falls back to custom for slugs it doesn't know, so once it picks up this version, SMUS partial connections get SaaS too.

pyatlan_v9 re-exports this enum, so it needs no separate change. atlan-java gets the same entry in atlanhq/atlan-java#2812.

Jira link: n/a

Type of change

  • New feature (non-breaking change that adds functionality)

How has this been tested?

On this branch:

  • AtlanConnectorType("aws-smus") returns AWS_SMUS, and .category.value is "SaaS".
  • get_connector_name("default/aws-smus/<epoch>") returns aws-smus, and _get_connector_type_from_qualified_name returns AWS_SMUS rather than a custom type.
  • Connection.creator(client=<mock>, name="smus-test", connector_type=AtlanConnectorType.AWS_SMUS, admin_users=[...]) builds default/aws-smus/<epoch> with connector_name="aws-smus" and category="SaaS".
  • pyatlan_v9.model.enums.AtlanConnectorType.AWS_SMUS is the same member.
  • ruff format --check and ruff check (0.15.22) pass on the file.
  • pytest tests/unit: 7206 passed, 5 skipped. pytest tests_v9/unit: 7919 passed, 5 skipped.

Checklist

  • My code follows the project's style guidelines
  • I've performed a self-review of my code
  • I've added comments in tricky or complex areas (n/a, single enum entry)
  • I've updated the documentation as needed (n/a)
  • There are no new warnings from my changes
  • I've added tests to cover my changes (single enum entry, same as PARTCON-28: Add INFORMATICA_POWERCENTER connector type聽#979)
  • All new and existing tests pass locally

馃 Generated with Claude Code

AWS SageMaker Unified Studio connections use the connector name aws-smus,
which AtlanConnectorType doesn't list, so Connection.creator can't create
one. The category is SaaS, which is what the Atlan UI sets on these
connections.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zaman-atlan
zaman-atlan marked this pull request as ready for review October 15, 2026 05:17

@Aryamanz29 Aryamanz29 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@Aryamanz29
Aryamanz29 merged commit 74b05aa into main Oct 15, 2026
63 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants