Repository navigation
feat: add AWS_SMUS connector type - #1088
Merged
Merged
Conversation
AWS SageMaker Unified Studio connections use the connector name aws-smus, which AtlanConnectorType doesn't list, so Connection.creator can't create one. The category is SaaS, which is what the Atlan UI sets on these connections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zaman-atlan
marked this pull request as ready for review
October 15, 2026 05:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AtlanConnectorTypehas no entry for AWS SageMaker Unified Studio, whose connector name isaws-smus. Without it,Connection.creator(connector_type=...)can't create an SMUS connection, and scripts have to fall back toAtlanConnectorType.CREATE_CUSTOM.This adds
AWS_SMUS = ("aws-smus", AtlanConnectionCategory.SAAS)next toAWS_SAGEMAKER. The category isSaaSbecause that's what the Atlan UI sets on the SMUS connections it creates. atlan-publish-app also takes partial-Connection categories from this enum and falls back tocustomfor slugs it doesn't know, so once it picks up this version, SMUS partial connections getSaaStoo.pyatlan_v9re-exports this enum, so it needs no separate change. atlan-java gets the same entry in atlanhq/atlan-java#2812.Jira link: n/a
Type of change
How has this been tested?
On this branch:
AtlanConnectorType("aws-smus")returnsAWS_SMUS, and.category.valueis"SaaS".get_connector_name("default/aws-smus/<epoch>")returnsaws-smus, and_get_connector_type_from_qualified_namereturnsAWS_SMUSrather than a custom type.Connection.creator(client=<mock>, name="smus-test", connector_type=AtlanConnectorType.AWS_SMUS, admin_users=[...])buildsdefault/aws-smus/<epoch>withconnector_name="aws-smus"andcategory="SaaS".pyatlan_v9.model.enums.AtlanConnectorType.AWS_SMUSis the same member.ruff format --checkandruff check(0.15.22) pass on the file.pytest tests/unit: 7206 passed, 5 skipped.pytest tests_v9/unit: 7919 passed, 5 skipped.Checklist
馃 Generated with Claude Code