Repository navigation
Skip query machinery when promoting disk-cached values - #9
Closed
charliermarsh wants to merge 1 commit into
Closed
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
force-pushed
the
charlie/ohm-incremental-cache-promotion
branch
from
August 3, 2026 13:31
e1974df to
2b19dbb
Compare
charliermarsh
changed the base branch from
charlie/ohm-emit-rlink
to
charlie/pin-ohm-cargo-defaults
August 3, 2026 13:31
charliermarsh
force-pushed
the
charlie/ohm-incremental-cache-promotion
branch
from
August 15, 2026 12:07
2b19dbb to
cf7b24e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport rust-lang/rust#158059 to the Ohm Rust 1.97.1 line. At the end of an incremental compiler session, green queries that were not needed during the current run must still be promoted from the previous on-disk cache into the next cache. Load those values directly into the in-memory query cache instead of reentering the full query execution machinery, while preserving the existing incremental fingerprint verification policy. Upstream measured 1.3% fewer instructions on average, concentrated in unchanged incremental builds, and 0.36% fewer instructions for patched incremental builds.