Repository navigation
Skip query machinery when promoting disk-cached values - #44
Closed
charliermarsh wants to merge 1 commit into
Closed
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
force-pushed
the
charlie/1.98/ohm-incremental-cache-promotion
branch
from
August 21, 2026 12:20
b7a8ef9 to
ab0f235
Compare
charliermarsh
force-pushed
the
charlie/1.98/ohm-incremental-cache-promotion
branch
from
August 31, 2026 13:08
ab0f235 to
4502fd3
Compare
charliermarsh
force-pushed
the
charlie/1.98/rdr-reachability-1.98.0
branch
from
August 31, 2026 13:08
0af9ff7 to
024a3da
Compare
charliermarsh
force-pushed
the
charlie/1.98/rdr-reachability-1.98.0
branch
from
September 1, 2026 17:56
024a3da to
eeb0c4d
Compare
charliermarsh
force-pushed
the
charlie/1.98/ohm-incremental-cache-promotion
branch
2 times, most recently
from
September 1, 2026 18:05
519c186 to
24b0f91
Compare
charliermarsh
force-pushed
the
charlie/1.98/rdr-reachability-1.98.0
branch
2 times, most recently
from
September 1, 2026 19:00
1e96319 to
bd13efb
Compare
charliermarsh
force-pushed
the
charlie/1.98/ohm-incremental-cache-promotion
branch
from
September 1, 2026 19:00
24b0f91 to
10b3fe8
Compare
charliermarsh
force-pushed
the
charlie/1.98/rdr-reachability-1.98.0
branch
from
September 3, 2026 14:24
bd13efb to
aa47efa
Compare
charliermarsh
force-pushed
the
charlie/1.98/ohm-incremental-cache-promotion
branch
2 times, most recently
from
September 3, 2026 18:17
5b094b7 to
e6d7b76
Compare
charliermarsh
force-pushed
the
charlie/1.98/rdr-reachability-1.98.0
branch
from
September 8, 2026 21:06
279048b to
dd49c81
Compare
charliermarsh
force-pushed
the
charlie/1.98/ohm-incremental-cache-promotion
branch
from
September 8, 2026 21:06
e6d7b76 to
0ed4acc
Compare
charliermarsh
force-pushed
the
charlie/1.98/rdr-reachability-1.98.0
branch
from
September 16, 2026 16:39
dd49c81 to
fb44f15
Compare
charliermarsh
force-pushed
the
charlie/1.98/ohm-incremental-cache-promotion
branch
from
September 16, 2026 16:39
0ed4acc to
30c47f2
Compare
charliermarsh
force-pushed
the
charlie/1.98/rdr-reachability-1.98.0
branch
from
September 16, 2026 19:07
fb44f15 to
fca8696
Compare
charliermarsh
force-pushed
the
charlie/1.98/ohm-incremental-cache-promotion
branch
from
September 16, 2026 19:07
30c47f2 to
c3b21c7
Compare
Ported from #9 to Rust 1.98.0. # Conflicts: # compiler/rustc_query_impl/src/execution.rs # compiler/rustc_query_impl/src/incremental.rs
charliermarsh
changed the base branch from
charlie/1.98/rdr-reachability-1.98.0
to
ohm-1.99.0
October 1, 2026 15:57
charliermarsh
force-pushed
the
charlie/1.98/ohm-incremental-cache-promotion
branch
from
October 1, 2026 16:02
c3b21c7 to
7ed4823
Compare
charliermarsh
changed the base branch from
ohm-1.99.0
to
charlie/1.98/rdr-reachability-1.98.0
October 1, 2026 16:04
charliermarsh
changed the base branch from
charlie/1.98/rdr-reachability-1.98.0
to
ohm-1.99.0
October 1, 2026 16:18
charliermarsh
changed the base branch from
ohm-1.99.0
to
charlie/1.98/rdr-reachability-1.98.0
October 1, 2026 16:24
Collaborator
Author
|
Dropped this empty layer from the active stack. On the Rust 1.99 base, its head and parent have exactly the same Git tree. The implementation is already present upstream, so removing this commit and retargeting the next layer changes no source. This closes obsolete stack history; it does not remove the upstream behavior. Report and exact tree-equality evidence: astral-experiments/ohm#144. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load unchanged disk-cached query results directly when promoting them into the next incremental session. These queries are already known to be green, so we can skip the normal query lookup and execution machinery.
Loaded values still go through the existing incremental fingerprint verification.
Rust 1.99 includes this implementation upstream; the existing PR is retained with an empty diff.