Skip to content

Skip query machinery when promoting disk-cached values - #44

Closed
charliermarsh wants to merge 1 commit into
charlie/1.98/rdr-reachability-1.98.0from
charlie/1.98/ohm-incremental-cache-promotion
Closed

charliermarsh wants to merge 1 commit into
charlie/1.98/rdr-reachability-1.98.0from
charlie/1.98/ohm-incremental-cache-promotion

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Aug 21, 2026 •

Copy link
Copy Markdown
Collaborator

Load unchanged disk-cached query results directly when promoting them into the next incremental session. These queries are already known to be green, so we can skip the normal query lookup and execution machinery.

Loaded values still go through the existing incremental fingerprint verification.

Rust 1.99 includes this implementation upstream; the existing PR is retained with an empty diff.

@charliermarsh
charliermarsh force-pushed the charlie/1.98/ohm-incremental-cache-promotion branch from b7a8ef9 to ab0f235 Compare August 21, 2026 12:20
@charliermarsh
charliermarsh force-pushed the charlie/1.98/ohm-incremental-cache-promotion branch from ab0f235 to 4502fd3 Compare August 31, 2026 13:08
@charliermarsh
charliermarsh force-pushed the charlie/1.98/rdr-reachability-1.98.0 branch from 0af9ff7 to 024a3da Compare August 31, 2026 13:08
@codspeed

codspeed Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 22 untouched benchmarks


Comparing charlie/1.98/ohm-incremental-cache-promotion (0ed4acc) with charlie/1.98/rdr-reachability-1.98.0 (dd49c81)

Open in CodSpeed

@charliermarsh
charliermarsh force-pushed the charlie/1.98/rdr-reachability-1.98.0 branch from 024a3da to eeb0c4d Compare September 1, 2026 17:56
@charliermarsh
charliermarsh force-pushed the charlie/1.98/ohm-incremental-cache-promotion branch 2 times, most recently from 519c186 to 24b0f91 Compare September 1, 2026 18:05
@charliermarsh
charliermarsh force-pushed the charlie/1.98/rdr-reachability-1.98.0 branch 2 times, most recently from 1e96319 to bd13efb Compare September 1, 2026 19:00
@charliermarsh
charliermarsh force-pushed the charlie/1.98/ohm-incremental-cache-promotion branch from 24b0f91 to 10b3fe8 Compare September 1, 2026 19:00
@charliermarsh
charliermarsh force-pushed the charlie/1.98/rdr-reachability-1.98.0 branch from bd13efb to aa47efa Compare September 3, 2026 14:24
@charliermarsh
charliermarsh force-pushed the charlie/1.98/ohm-incremental-cache-promotion branch 2 times, most recently from 5b094b7 to e6d7b76 Compare September 3, 2026 18:17
@charliermarsh
charliermarsh force-pushed the charlie/1.98/rdr-reachability-1.98.0 branch from 279048b to dd49c81 Compare September 8, 2026 21:06
@charliermarsh
charliermarsh force-pushed the charlie/1.98/ohm-incremental-cache-promotion branch from e6d7b76 to 0ed4acc Compare September 8, 2026 21:06
@charliermarsh
charliermarsh force-pushed the charlie/1.98/rdr-reachability-1.98.0 branch from dd49c81 to fb44f15 Compare September 16, 2026 16:39
@charliermarsh
charliermarsh force-pushed the charlie/1.98/ohm-incremental-cache-promotion branch from 0ed4acc to 30c47f2 Compare September 16, 2026 16:39
@charliermarsh
charliermarsh force-pushed the charlie/1.98/rdr-reachability-1.98.0 branch from fb44f15 to fca8696 Compare September 16, 2026 19:07
@charliermarsh
charliermarsh force-pushed the charlie/1.98/ohm-incremental-cache-promotion branch from 30c47f2 to c3b21c7 Compare September 16, 2026 19:07
@charliermarsh
charliermarsh removed this pull request from stack #135 September 16, 2026 19:08
Ported from #9 to Rust 1.98.0.

# Conflicts:
#	compiler/rustc_query_impl/src/execution.rs
#	compiler/rustc_query_impl/src/incremental.rs
@charliermarsh
charliermarsh removed this pull request from stack #143 October 1, 2026 15:57
@charliermarsh
charliermarsh changed the base branch from charlie/1.98/rdr-reachability-1.98.0 to ohm-1.99.0 October 1, 2026 15:57
@charliermarsh
charliermarsh force-pushed the charlie/1.98/ohm-incremental-cache-promotion branch from c3b21c7 to 7ed4823 Compare October 1, 2026 16:02
@charliermarsh
charliermarsh changed the base branch from ohm-1.99.0 to charlie/1.98/rdr-reachability-1.98.0 October 1, 2026 16:04
@charliermarsh
charliermarsh added this pull request to stack #150 October 1, 2026 16:06
@charliermarsh
charliermarsh removed this pull request from stack #150 October 1, 2026 16:18
@charliermarsh
charliermarsh changed the base branch from charlie/1.98/rdr-reachability-1.98.0 to ohm-1.99.0 October 1, 2026 16:18
@charliermarsh
charliermarsh changed the base branch from ohm-1.99.0 to charlie/1.98/rdr-reachability-1.98.0 October 1, 2026 16:24
@charliermarsh
charliermarsh added this pull request to stack #152 October 1, 2026 16:25
@charliermarsh
charliermarsh removed this pull request from stack #152 October 1, 2026 16:36
@charliermarsh
charliermarsh added this pull request to stack #153 October 1, 2026 16:37
@charliermarsh
charliermarsh removed this pull request from stack #153 October 7, 2026 14:09
@charliermarsh

Copy link
Copy Markdown
Collaborator Author

Dropped this empty layer from the active stack. On the Rust 1.99 base, its head and parent have exactly the same Git tree. The implementation is already present upstream, so removing this commit and retargeting the next layer changes no source. This closes obsolete stack history; it does not remove the upstream behavior.

Report and exact tree-equality evidence: astral-experiments/ohm#144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant