Skip to content

fix(cmake): Serialize test linking on Windows to avoid applocal races #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dino-saurabh wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −0
Open

fix(cmake): Serialize test linking on Windows to avoid applocal races #1064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a76e54b
fix(cmake): serialize test linking on Windows to avoid applocal races
Oct 25, 2026
c7f74aa
Update src/iceberg/test/CMakeLists.txt
dino-saurabh Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/iceberg/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ set(ICEBERG_TEST_RESOURCES "${CMAKE_SOURCE_DIR}/src/iceberg/test/resources")

configure_file("test_config.h.in" "test_config.h")

# vcpkg's z-applocal POST_BUILD copies dependency DLLs into this shared test
# directory. Ninja appends that command to the link recipe, so a link pool of
# depth 1 also serializes the copies. Parallel copies fail with a file lock
# (https://github.com/apache/iceberg-cpp/issues/944).
if(WIN32 AND CMAKE_GENERATOR MATCHES "Ninja")
Comment thread
dino-saurabh marked this conversation as resolved.
set_property(GLOBAL APPEND PROPERTY JOB_POOLS test_link_job_pool=1)
set(CMAKE_JOB_POOL_LINK test_link_job_pool)
endif()

function(add_iceberg_test test_name)
set(options USE_BUNDLE USE_DATA)
set(oneValueArgs)
Expand Down
Loading