Repository navigation
fix(cmake): Serialize test linking on Windows to avoid applocal races - #1064
Open
dino-saurabh wants to merge 2 commits into
Open
dino-saurabh wants to merge 2 commits into
dino-saurabh wants to merge 2 commits into
Conversation
vcpkg's post-link z-applocal steps copy DLLs into the shared test directory and collide when Ninja links tests in parallel. Link tests one at a time on Windows (https://cmake.org/cmake/help/latest/variable/WIN32.html). Closes apache#944
dino-saurabh
changed the title
dino-saurabh
marked this pull request as ready for review
October 26, 2026 17:37
zhjwpku
approved these changes
Oct 27, 2026
Adding suggested comments. Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
zhjwpku
added
the
ready to merge
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vcpkg's post-link z-applocal steps copy DLLs into the shared test directory and collide when Ninja links tests in parallel. Link tests one at a time on Windows (https://cmake.org/cmake/help/latest/variable/WIN32.html).
Closes #944