Repository navigation
Count actor DNS queries by egress policy decision - #3395
Open
Lior Lieberman (LiorLieberman) wants to merge 3 commits into
Open
Lior Lieberman (LiorLieberman) wants to merge 3 commits into
Lior Lieberman (LiorLieberman) wants to merge 3 commits into
Conversation
Signed-off-by: Lior Lieberman <liorlieberman@google.com>
Signed-off-by: Lior Lieberman <liorlieberman@google.com>
Signed-off-by: Lior Lieberman <liorlieberman@google.com>
Lior Lieberman (LiorLieberman)
force-pushed
the
dns-denied-metric
branch
2 times, most recently
from
November 13, 2026 19:11
0ea06e3 to
f9c8c40
Compare
Lior Lieberman (LiorLieberman)
marked this pull request as ready for review
November 13, 2026 19:11
Bowei Du (bowei)
approved these changes
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3228. The sandbox DNS relay answers a name the egress policy doesn't allow with NXDOMAIN, and nothing counted those denials.
Both ateworkers now emit
ate.dns.querieswith anate.dns.decisionlabel,allowedordenied. A denied query gets NXDOMAIN.There's no actor or atespace label, per the cardinality rules. A log of which actor looked up which name could come in a follow-up.
AI use: AI-assisted for code and tests, I reviewed the diff.