Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions org-tools/governance/rules/conformance-rules.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,12 @@ rules:
- ".pre-commit-config.yaml"
- "README.md"
- "*.py"
- "common/**"
- "core/**"
- "framework/**"
- "platforms/**"
- "pyproject.toml"
- "shopping/**"
- "shopping-agent-test.json"
- "test_data/**"
requires:
Expand Down
25 changes: 25 additions & 0 deletions org-tools/governance/tests/test_governance_config_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,31 @@ def test_ucp_rules_agent_markdown_globs(self):
self.assertEqual(file_reqs[0].min_team, Team("devops-maintainers", 1))
self.assertEqual(file_reqs[0].min_approvals, 2)

def test_conformance_rules_suite_directory_globs(self):
"""Test that RFC #520 suite directories match infra_and_tooling, not fallback."""
rules_path = (
Path(__file__).resolve().parent.parent / "rules" / "conformance-rules.yml"
)
config = GovernanceConfigParser().parse_file(str(rules_path))
reqs = config.get_applicable_requirements(
[
"framework/base_test.py",
"framework/__init__.py",
"platforms/google.yaml",
"shopping/checkout_lifecycle_test.py",
"shopping/test_data/flower_shop/products.csv",
"common/webhook_test.py",
"core/discovery_test.py",
"runner.py",
]
)
for filename, file_reqs in reqs.items():
self.assertEqual(
len(file_reqs), 1, f"Unexpected requirements for {filename}"
)
self.assertEqual(file_reqs[0].min_team, Team("devops-maintainers", 1))
self.assertEqual(file_reqs[0].min_approvals, 2)


if __name__ == "__main__":
unittest.main()
Loading