Repository navigation
fix(governance): match RFC #520 directories under infra_and_tooling i… - #87
Merged
Merged
Conversation
…n conformance-rules.yml
damaz91
approved these changes
Nov 4, 2026
ptiper
approved these changes
Nov 5, 2026
ptiper
left a comment
Contributor
There was a problem hiding this comment.
Approving given refactoring, but please update down the line to the proper governance enforcement please.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The conformance restructure from RFC #520 adds new top-level directories to conformance. None of them match a rule in conformance-rules.yml, so they fall through to the fallback requirement (2 approvals from governance-council). The current infra_and_tooling pattern ".py" only matches root-level files, because the governance glob engine maps * to [^/].
As a result, conformance#120 (framework + runner) can't pass Governance / Approvals with devops/maintainer approvals alone, even though it's the same kind of test-tooling change that infra_and_tooling already covers. I confirmed this by running PullRequestValidator against #120's 14 files: with 2 devops-maintainers approvals, infra_and_tooling is satisfied (2/2) but governance-council is still 0/2. The next PRs in the series hit the same problem: #121
adds shopping/ and common/, and PR 3/3 adds core/.
This PR adds the five RFC #520 directories to infra_and_tooling in org-tools/governance/rules/conformance-rules.yml:
This keeps the same approval bar the repo already uses for test code (*.py, test_data/**): 2 approvals from devops-maintainers or higher. It also adds a regression test (test_conformance_rules_suite_directory_globs) that asserts representative files in each directory resolve to infra_and_tooling rather than fallback, following the pattern from #82.
Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
Unblocks Universal-Commerce-Protocol/conformance#120 and Universal-Commerce-Protocol/conformance#121 (RFC Universal-Commerce-Protocol/ucp#520).
Checklist
!for breaking changes).Screenshots / Logs (if applicable)