Repository navigation
docs: clarify inherited reporter resolutions (L-03) - #81
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
chrismaree
left a comment
There was a problem hiding this comment.
Reviewed against L-03 / FRO-149 at 2862544. This implements the documentation alternative explicitly offered in the finding and matches the intended market-recreation behavior discussed with OZ. The docs now correctly say registration immediately exposes the shared settled outcome, initialization only adds a callback attempt, and permissionless reporting does not wait for initialization. They also explain the absence of a new oracle round, terminal resolution, and the need to distinguish periods and numerical outcome mappings in rules. The added assertions check outcome availability before initialization, addressing the previous feedback.
This approves the documented disposition; it does not add a guard against reusing incorrectly domain-separated rules or represent OZ's final closure. Static code and test review; no tests or builds run.
Clarify that registering a duplicate immediately exposes the canonical state and settled outcome, without a new oracle round. Initialization adds a callback attempt; it does not gate reads or permissionless reporting. Document that distinct periods and numerical position mappings must be distinguished in the rules.
Addresses the documentation alternative in L-03. Existing shared-resolution behavior is preserved.
Base: #76. Tracks FRO-149.
Validation: reviewed against registration and initialization paths; production Solidity changes are comments only; the late-duplicate test now verifies resolved state and outcome immediately after registration, before initialization, and passes;
forge fmt --check src/reporters/interfaces/IOOReporter.solandgit diff --checkpass.