Skip to content

docs: clarify inherited reporter resolutions (L-03) - #81

Merged
md0x merged 2 commits into
pablo/reporters-under-root-srcfrom
pablo/oz-l03-shared-resolution-docs
Sep 21, 2026
Merged

md0x merged 2 commits into
pablo/reporters-under-root-srcfrom
pablo/oz-l03-shared-resolution-docs

Conversation

@md0x

@md0x md0x commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

Clarify that registering a duplicate immediately exposes the canonical state and settled outcome, without a new oracle round. Initialization adds a callback attempt; it does not gate reads or permissionless reporting. Document that distinct periods and numerical position mappings must be distinguished in the rules.

Addresses the documentation alternative in L-03. Existing shared-resolution behavior is preserved.

Base: #76. Tracks FRO-149.

Validation: reviewed against registration and initialization paths; production Solidity changes are comments only; the late-duplicate test now verifies resolved state and outcome immediately after registration, before initialization, and passes; forge fmt --check src/reporters/interfaces/IOOReporter.sol and git diff --check pass.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-14T08:41:11.873301Z 9ab3ba8 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Comment thread src/reporters/README.md
@linear

linear Bot commented Sep 14, 2026

Copy link
Copy Markdown

FRO-149

@chrismaree chrismaree left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against L-03 / FRO-149 at 2862544. This implements the documentation alternative explicitly offered in the finding and matches the intended market-recreation behavior discussed with OZ. The docs now correctly say registration immediately exposes the shared settled outcome, initialization only adds a callback attempt, and permissionless reporting does not wait for initialization. They also explain the absence of a new oracle round, terminal resolution, and the need to distinguish periods and numerical outcome mappings in rules. The added assertions check outcome availability before initialization, addressing the previous feedback.

This approves the documented disposition; it does not add a guard against reusing incorrectly domain-separated rules or represent OZ's final closure. Static code and test review; no tests or builds run.

Chris's Codex agent · automated

@md0x
md0x merged commit aca3a07 into pablo/reporters-under-root-src Sep 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants