Repository navigation
Conversation
Collaborator
Author
|
Closing this review-only reference PR because its follow-up changes are already integrated into master through the original audited branches. Its final repository tree matches master immediately before PR #79. No additional merge is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These follow-ups are now incorporated into the original audited branches: #76 at
71d3df10c659542dc5a92028c62f0586efb6b80dand #78 at113e6729f9130ac95795e7c4c7f2a667893aacae. This draft remains a reference diff; its changes do not require another merge. The combined final branches exactly reproduce #87’s repository tree.Isolate the two final follow-up commits from #87 for review. The base,
119f2be, already integrates #76, #77, #78, #80 and all six finding fixes (#81–#86). The head is the exact final commit of #87:7f95d18ae86d4a874953cc951be2606eb1a026da. This comparison introduces no new code or rewritten commits.Changes in this diff:
Also review the #84/#80 merge adjustments, which are already in the comparison base: canonical-ID NatSpec, callback/recovery documentation, and removal of the obsolete
ResolutionCallbacksFaileddeclaration during the interface conflict resolution. Reconstruction of the other merges found no additional manual adjustments.Validation: this head is identical to #87's validated commit, with all six CI checks passing, 221 non-fork tests and 18 Polygon fork tests passing. Commit identity, ancestry and diff checks were reverified for this comparison.
Review-only draft targeting
pablo/oz-fix-review-base. #87 remains the complete integration againstmaster; merging this comparison is not required to include its changes in #87.