Skip to content

Review final audit integration follow-ups - #88

Closed
md0x wants to merge 2 commits into
pablo/oz-fix-review-basefrom
pablo/oz-review-followups
Closed

md0x wants to merge 2 commits into
pablo/oz-fix-review-basefrom
pablo/oz-review-followups

Conversation

@md0x

@md0x md0x commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

These follow-ups are now incorporated into the original audited branches: #76 at 71d3df10c659542dc5a92028c62f0586efb6b80d and #78 at 113e6729f9130ac95795e7c4c7f2a667893aacae. This draft remains a reference diff; its changes do not require another merge. The combined final branches exactly reproduce #87’s repository tree.

Isolate the two final follow-up commits from #87 for review. The base, 119f2be, already integrates #76, #77, #78, #80 and all six finding fixes (#81–#86). The head is the exact final commit of #87: 7f95d18ae86d4a874953cc951be2606eb1a026da. This comparison introduces no new code or rewritten commits.

Changes in this diff:

  • Accept registered aliases in both pre- and post-upgrade reporter validation, preserving full request-state checks. Add an upgrade regression that accepts aliases and rejects mismatched logs or changed state.
  • Document the integrated ERC-7201/UUPS layout and its incompatibility with the original managed-oracle: add UUPS upgradeability to SignedProposer #78 layout; update upgrade-validation documentation and format the canonical-ID NatSpec.
  • Increase the large-revert test budget from 2M to 2.8M for the proxy's returndata copy. Production gas behavior is unchanged by this test adjustment.

Also review the #84/#80 merge adjustments, which are already in the comparison base: canonical-ID NatSpec, callback/recovery documentation, and removal of the obsolete ResolutionCallbacksFailed declaration during the interface conflict resolution. Reconstruction of the other merges found no additional manual adjustments.

Validation: this head is identical to #87's validated commit, with all six CI checks passing, 221 non-fork tests and 18 Polygon fork tests passing. Commit identity, ancestry and diff checks were reverified for this comparison.

Review-only draft targeting pablo/oz-fix-review-base. #87 remains the complete integration against master; merging this comparison is not required to include its changes in #87.

@md0x

md0x commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator Author

Closing this review-only reference PR because its follow-up changes are already integrated into master through the original audited branches. Its final repository tree matches master immediately before PR #79. No additional merge is needed.

@md0x md0x closed this Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant