Repository navigation
Add partial-success batching and UUPS upgrades to SignedProposer - #77
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
chrismaree
force-pushed
the
chrismaree/signed-proposer
branch
from
August 31, 2026 13:01
733aec2 to
32e23e4
Compare
This was referenced Sep 8, 2026
This was referenced Sep 14, 2026
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds partial-success proposal batching to SignedProposer and deploys it behind a UUPS/ERC1967 proxy. Delegated relayers can submit independent proposal attempts in one transaction; the default administrator authorizes upgrades.
tryMulticallaccepts onlypropose, preserves the caller, blocks nested batches with an ERC-7201 lock, and returns per-call success flags. Failure metadata is capped at 256 bytes. There is no per-child gas cap, and insufficient outer gas can still revert the whole batch, including through proxy returndata copying.permit2at slot 0, offset 0; it is incompatible with the original managed-oracle: add UUPS upgradeability to SignedProposer #78 proposal's offset-1 layout. No storage migration is included.multicallretains its existing behavior.Final commit:
5b87be6b70c7cb0e2d977d57f8a6023f7f68ca7e. Its complete repository tree is identical to the reviewed #78 commit113e6729f9130ac95795e7c4c7f2a667893aacae.Validation: all eight CI checks passed on that identical reviewed tree, covering unit tests, Polygon forks and production upgrade forks. The 67 SignedProposer tests also passed locally. Tree equality and diff checks passed after the squash merge; CI is rerunning on the new commit.