Repository navigation
[9/11] fix(readability): the 1x audit; the inventory covers every atlas - #225
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
area:art
arudaev
changed the title
github-actions
Bot
added
the
area:delivery
arudaev
changed the title
arudaev
force-pushed
the
playtest/9-readability
branch
from
October 25, 2026 10:23
8094372 to
b596b7c
Compare
… actor rim #159: readability.py --all over every exported atlas (90 frames on the stage they appear on): 77 readable, 13 low, and every low one reads with the actors' rim. All of them get it in the game except the pickups the coffee visit tosses (the pocket computer, the food), which get it now. Every atlas is also clean over purple and white (backdrop_check.py). Refs #159
…it to that inventory never listed (hero-ladder was one). The inventory gains the rubber chicken, the arena wall, platform and chain (the last two are composed into the arena plate, so they stay 'drawn'), and the art pipeline runs assets.py status --strict. Refs #158
arudaev
force-pushed
the
playtest/9-readability
branch
from
October 25, 2026 11:57
b596b7c to
121486d
Compare
arudaev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: 9 of 11 (playtest): base #224. Merge bottom-up, only on Alexander's word.
What and why
#159 left one thing open: "the 1x contact-sheet audit of every atlas and the redraws that fail it".
readability.py --all, every clip of every exported atlas (90 frames, 27 boards, including today's rubber chicken and arena wall) at game size on the stage it appears on. The sheet isart/sprites/previews/readability-audit.png.CoffeeVisit.toss).fx-ground:grassscores LOW and isn't rimmed on purpose: grass kicked up in grass is meant to blend.backdrop_check.py: no key specks, no soft pixels, on all 27.And #158, the asset system (second commit):
assets.py statusnow also reports an atlas the game loads thatart/inventory.csvnever listed.hero-ladderwas one.assets.py status --strict, so the inventory can't drift from the files again.check_docsnow fails on double-encoded text in any.md,.json,.ts,.pyor.csv.Issue
Refs #159 and #158. With this PR, the audit and the legibility check of its acceptance criteria are done. The before/after redraw comparison has nothing to compare.
Verification
npm test: 336 passed;tscclean;check_docsclean.readability.py --all:77 readable, 13 low, 0 still low with the rim.