Repository navigation
[10/11] refactor(story): Jenny's ram and Dexter's hop by their boards - #229
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
area:enemies
arudaev
changed the title
arudaev
force-pushed
the
playtest/10-ram-timing
branch
from
October 25, 2026 10:23
4b6d246 to
70d5922
Compare
arudaev
force-pushed
the
playtest/10-ram-timing
branch
from
October 25, 2026 11:57
70d5922 to
b352c47
Compare
arudaev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: 10 of 11 (playtest): base #225. Merge bottom-up, only on Alexander's word.
What and why
#156, "one timing source": the last gameplay code that timed frames as
n / 12.jennyRam.tsramFrame): her rev, charge and crash frames and the hero's thrownhitframes come from the loadedboss-jennyandhero-hurttables, whichFlow.rampasses in.DexterGuide,hopClip) and the shove's contact frame (Prologue) come fromdexter.anims.json.HOP_CLIP,LANDING_TIMES). The ladder ends' times are pinned tohero-ladder.anims.jsonby a test.Issue
Refs #156. With this PR the "one timing source" criterion is met. Still open in #156: walk and run speeds measured from the strides, the transition GIFs, and the recorded keyboard-and-pad playtest.
Verification
npm test: 336 passed (unchanged behaviour on the defaults);tscclean.