Skip to content

Fix MidiIn.close_port docstring (comparison instead of assignment) #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iDoMeteor wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix MidiIn.close_port docstring (comparison instead of assignment) #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/_rtmidi.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,7 @@ cdef class MidiIn(MidiBase):
self.cancel_callback()
MidiBase.close_port(self)

close_port.__doc__ == MidiBase.close_port.__doc__
close_port.__doc__ = MidiBase.close_port.__doc__

def get_message(self):
"""Poll for MIDI input.
Expand Down
3 changes: 3 additions & 0 deletions tests/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ def test_get_api_name(self):
self.assertEqual(rtmidi.get_api_name(rtmidi.API_WINDOWS_MM), 'winmm')
self.assertEqual(rtmidi.get_api_name(rtmidi.API_WEB_MIDI), 'web')

def test_midiin_close_port_docstring(self):
self.assertEqual(rtmidi.MidiIn.close_port.__doc__, rtmidi._rtmidi.MidiBase.close_port.__doc__)

def test_get_compiled_api(self):
apilist = rtmidi.get_compiled_api()
self.assertTrue(isinstance(apilist, list))
Expand Down