Conversation
In MidiIn, the line
close_port.__doc__ == MidiBase.close_port.__doc__
is a comparison, not an assignment, so it did nothing and MidiIn.close_port
only had the signature that Cython embeds ("MidiIn.close_port(self)"),
while MidiBase.close_port documents that it also cancels the callback.
Use a plain assignment, which Cython accepts in a cdef class body, so that
MidiIn.close_port gets the docstring of MidiBase.close_port, like the
other inherited methods. Add a test for it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
cdef class MidiIn, the line meant to copyclose_port's docstring fromMidiBaseis a comparison (==), not an assignment:so
rtmidi.MidiIn.close_port.__doc__holds only the embedded signature, not the documentation. This changes it to=; Cython 3 accepts the assignment in a cdef class body. A test intests/test_basic.pychecks that the docstring is set; it fails without the fix.Tested against a build of this branch on free-threaded CPython 3.14.7. It is independent of #230 and merges cleanly with it.
🤖 Generated with Claude Code