Repository navigation
Override search_cached_spikes_sorted for identity selections - #4845
Merged
alejoe91 merged 2 commits intoOct 9, 2026
Merged
Conversation
In SpikeInterface#4783 an identity selection of a lazy Zarr array shares the parent's lazy vector, but after SpikeInterface#4809 UnitSelectionSorting inherited the BaseSorting's search_cached_spike_sorted, which would see a non-ndarray and raise an error. The fix here is to just override the method and delegate the search to the parent for identity selections. Since the identity selection literally shares the parent's vector and segment slices, the parent's search is guaranteed to give the right positions.
grahamfindlay
changed the title
(cherry picked from commit edf5334)
Collaborator
Author
|
The Python 3.14 tests were failing because the tests from #4783 and #4809 were missing the newly required |
alejoe91
approved these changes
Oct 9, 2026
alejoe91
approved these changes
Oct 9, 2026
alejoe91
added a commit
to alejoe91/spikeinterface
that referenced
this pull request
Oct 9, 2026
…terface#4845) Co-authored-by: Alessio Buccino <alejoe9187@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4783 an identity selection of a lazy Zarr array shares the parent's
lazy vector, but after #4809 UnitSelectionSorting inherited the
BaseSorting's search_cached_spike_sorted, which would see a non-ndarray
and raise an error.
The fix here is to just override the method and delegate the search to
the parent for identity selections. Since the identity selection
literally shares the parent's vector and segment slices, the parent's
search is guaranteed to give the right positions.
@alejoe91