Skip to content

fix(scanner): preserve option values - #125

Open
John-David Dalton (jdalton) wants to merge 1 commit into
mainfrom
fix/socket-tier1-exclude-args
Open

John-David Dalton (jdalton) wants to merge 1 commit into
mainfrom
fix/socket-tier1-exclude-args

Conversation

@jdalton

@jdalton John-David Dalton (jdalton) commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Keep commas inside Tier 1 option values instead of splitting them into separate arguments. Repeated --exclude-paths options are documented, and malformed shell quoting gives a configuration error.

Verification covers argument parsing only, not end-to-end exclusions or a published image.

Implementation and validation

Only unquoted commas before a new hyphen-led option act as legacy separators. Documentation explains matching examples, Tier 1 scope, and the Basics workspace default.

Validation: 11 parser tests passed, covering repeated flags, comma lists, quoted/escaped commas, and invalid quoting. Black and Flake8 passed for the test module; git diff --check passed.

Automated review notes

[!NOTE]
Medium Risk
Changes how user-supplied Tier 1 scan CLI arguments are tokenized, which can alter reachability scan scope for existing socket_additional_params values that relied on old comma splitting.

Overview
Socket Tier 1 socket_additional_params / SOCKET_ADDITIONAL_PARAMS no longer splits on every comma, so values like --exclude-paths=tests,fixtures or quoted strings stay a single argument when forwarded to socket scan reach.

Parsing now uses shell-style quoting and only treats an unquoted comma before another - option as the legacy separator (e.g. --view=full,--all still works). Malformed quoting raises ConnectorExecutionError with a clear invalid-config message instead of silently mis-splitting.

Docs and GitHub Action / connector descriptions are updated to recommend space-separated options and repeated flags (e.g. multiple --exclude-paths), with examples for excluding paths from Tier 1 manifest discovery. New unit tests cover repeated flags, legacy commas, quoted/escaped commas, and bad quotes.

Reviewed by Cursor Bugbot for commit bf09322. Configure here.

@lelia

lelia commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit bf09322. Configure here.

This branch was successfully deployed

1 active deployment
socket-firewall — bf093221 Deployed Oct 11, 2026 by jdalton via python-sfw-smoke-enterprise #154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants