Repository navigation
feat: ci/cd gh actions #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| name: Backend CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - 'sticker-business/**' | ||
| - '.github/workflows/backend.yml' | ||
| pull_request: | ||
| paths: | ||
| - 'sticker-business/**' | ||
| - '.github/workflows/backend.yml' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| backend: | ||
| name: Backend build and tests | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Java | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 25 | ||
| cache: maven | ||
|
|
||
| - name: Build and test | ||
| run: ./mvnw -B clean verify | ||
| working-directory: sticker-business | ||
|
|
||
| database: | ||
| name: Database | ||
| runs-on: ubuntu-latest | ||
| services: | ||
| mysql: | ||
| image: mysql:8.4 | ||
| env: | ||
| MYSQL_ROOT_PASSWORD: ci-root-password | ||
| MYSQL_DATABASE: sticker_business | ||
| options: >- | ||
| --health-cmd="mysqladmin ping --host=127.0.0.1 --user=root --password=ci-root-password" | ||
| --health-interval=10s | ||
| --health-timeout=5s | ||
| --health-retries=10 | ||
| --health-start-period=30s | ||
| steps: | ||
| - name: Confirm MySQL is healthy | ||
| run: echo "MySQL 8.4 is ready." | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| name: Frontend CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - 'frontend/**' | ||
| - '.github/workflows/frontend.yml' | ||
| pull_request: | ||
| paths: | ||
| - 'frontend/**' | ||
| - '.github/workflows/frontend.yml' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| frontend: | ||
| name: Frontend build and checks | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
| cache: npm | ||
| cache-dependency-path: frontend/package-lock.json | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
| working-directory: frontend | ||
|
|
||
| - name: Test | ||
| run: npm test | ||
| working-directory: frontend | ||
|
|
||
| - name: Lint | ||
| run: npm run lint | ||
| working-directory: frontend | ||
|
|
||
| - name: Build and type-check | ||
| run: npm run build | ||
| working-directory: frontend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building the database is a good idea within the CI. The echo statement will always succeed and this creates false confidence in the state of the database, since nothing can actually fail it.
This is fine for now since this PR introduces CI when our application is still a skeleton. Once we have actual database work being performed by our application, we should add tests that run our code against a real MySQL database, so CI verifies our schema and queries work.