Repository navigation
feat: ci/cd gh actions - #53
Merged
Merged
Conversation
or8655
approved these changes
Nov 5, 2026
| --health-start-period=30s | ||
| steps: | ||
| - name: Confirm MySQL is healthy | ||
| run: echo "MySQL 8.4 is ready." |
Contributor
There was a problem hiding this comment.
Building the database is a good idea within the CI. The echo statement will always succeed and this creates false confidence in the state of the database, since nothing can actually fail it.
This is fine for now since this PR introduces CI when our application is still a skeleton. Once we have actual database work being performed by our application, we should add tests that run our code against a real MySQL database, so CI verifies our schema and queries work.
Wesley-Fos
added a commit
that referenced
this pull request
Nov 12, 2026
* build(deps-dev): bump vite from 8.3.2 to 8.3.5 in /frontend (#44) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 8.3.2 to 8.3.5. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.3.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 8.3.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(4up): week 11 (#49) * feat: ci/cd gh actions (#53) * feat: ci/cd gh actions * docs(README): Moving CI section for better flow * ci: run frontend and backend workflows on pushes to main --------- Co-authored-by: Wesley-Fos <wwf4167@rit.edu> Co-authored-by: Oscar Rojas-Perez <or8655@rit.edu> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oscar Rojas <94993190+or8655@users.noreply.github.com> Co-authored-by: Wesley-Fos <wwf4167@rit.edu> Co-authored-by: Oscar Rojas-Perez <or8655@rit.edu>
Wesley-Fos
added a commit
that referenced
this pull request
Nov 12, 2026
* build(deps-dev): bump vite from 8.3.2 to 8.3.5 in /frontend (#44) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 8.3.2 to 8.3.5. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.3.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 8.3.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(4up): week 11 (#49) * feat: ci/cd gh actions (#53) * feat: ci/cd gh actions * docs(README): Moving CI section for better flow * ci: run frontend and backend workflows on pushes to main --------- Co-authored-by: Wesley-Fos <wwf4167@rit.edu> Co-authored-by: Oscar Rojas-Perez <or8655@rit.edu> * feat: moving things and fixing merge conflicts --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oscar Rojas <94993190+or8655@users.noreply.github.com> Co-authored-by: Wesley-Fos <wwf4167@rit.edu> Co-authored-by: Oscar Rojas-Perez <or8655@rit.edu>
Wesley-Fos
added a commit
that referenced
this pull request
Nov 12, 2026
* test * feat: starter code for the mini algo * feat: moving things to appropriate folders * feat: adding X stickers to remove functionality * feat: adding comments and fixing file type * bug: removing test file * feat: moving stuff * feat: adding docs * docs(mini-algo): add comments explaining the fitTest algorithm * feat: fixing sticker properties and updating tests * docs: updating inline comments * docs: updating inline comments * bug: fixing test that was missing implementation * Feat/28 mini algo (#56) * build(deps-dev): bump vite from 8.3.2 to 8.3.5 in /frontend (#44) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 8.3.2 to 8.3.5. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.3.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 8.3.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(4up): week 11 (#49) * feat: ci/cd gh actions (#53) * feat: ci/cd gh actions * docs(README): Moving CI section for better flow * ci: run frontend and backend workflows on pushes to main --------- Co-authored-by: Wesley-Fos <wwf4167@rit.edu> Co-authored-by: Oscar Rojas-Perez <or8655@rit.edu> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oscar Rojas <94993190+or8655@users.noreply.github.com> Co-authored-by: Wesley-Fos <wwf4167@rit.edu> Co-authored-by: Oscar Rojas-Perez <or8655@rit.edu> * Feat/28 mini algo (#57) * build(deps-dev): bump vite from 8.3.2 to 8.3.5 in /frontend (#44) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 8.3.2 to 8.3.5. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v8.3.5/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 8.3.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs(4up): week 11 (#49) * feat: ci/cd gh actions (#53) * feat: ci/cd gh actions * docs(README): Moving CI section for better flow * ci: run frontend and backend workflows on pushes to main --------- Co-authored-by: Wesley-Fos <wwf4167@rit.edu> Co-authored-by: Oscar Rojas-Perez <or8655@rit.edu> * feat: moving things and fixing merge conflicts --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oscar Rojas <94993190+or8655@users.noreply.github.com> Co-authored-by: Wesley-Fos <wwf4167@rit.edu> Co-authored-by: Oscar Rojas-Perez <or8655@rit.edu> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Wesley-Fos <wwf4167@rit.edu> Co-authored-by: Oscar Rojas-Perez <or8655@rit.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oscar Rojas <94993190+or8655@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adding build/tests in GH actions
Issue/Story ticket number and link
41 #41
Checklist before requesting a review