Repository navigation
Hold multi_json at 1.19.1 in agent-runtime-8.x - #334
Conversation
|
Acceptance test for #333: OpenVoxProject/openvox#773 I ran it on my fork against the released openvox8 packages (agent 8.32.0, server 8.18.0), which carry the unpinned gem: https://github.com/miharp/openvox/actions/runs/42023349579
The test should go green once a runtime with this change is promoted into openvox 8.x. |
|
I think the TL;DR is that multi_json 1.20 bumped the min Ruby version to 3.2, and JRuby 9.4 is technically MRI 3.1 compatible, yes? |
agent-runtime-8.x installs multi_json into the vendor gem directory that puppetserver also loads from. Since OpenVoxProject#288 that has been 1.21.2, which OpenVox Server 8 cannot load. The ruby platform gem has no JRuby options cache backend, and 1.20.0 and later need Ruby 3.2 while the server runs JRuby 9.4 (Ruby 3.1). From openvox-agent 8.31.1 on, `require 'multi_json'` fails on the server with a LoadError. Override the version where ruby_version is 3.2, after the section update_gems maintains. The automation keeps other projects on the latest release and does not touch the override. Fixes OpenVoxProject#333 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Michael Harp <mike@mikeharp.com>
49bb038 to
c8088f4
Compare
|
Half of it. 1.20 did raise the minimum to Ruby 3.2, and JRuby 9.4 is 3.1. The LoadError in #333 is the other half: 1.20 also split into ruby and java platform gems, and the ruby one we install has no Switched to the |
Fixes #333.
Since #288 the 8.x agent runtime ships multi_json 1.21.2 in the vendor gem directory that puppetserver also loads from. OpenVox Server 8 cannot load it, so
require 'multi_json'fails on the server from openvox-agent 8.31.1 on. The issue has the details and a container repro.Changes:
rubygem-multi_json.rbsets the version to 1.19.1 whereruby_versionis3.2. Onlyagent-runtime-8.xsets that.openbolt-runtimekeeps following the latest release.update_gemsmaintains. The automation only rewrites lines inside that section, so it keeps updating the version there and leaves the override alone. In the issue I wrote that a per-project conditional would not survive a bot run. That only holds inside the maintained section.Verified:
vanagon inspect <project> el-9-x86_64:rake vox:update_gems_wo_commitwith the maintained version set back to 1.21.1: it rewrote the section to 1.21.2 and did not touch the override.A container with openvox-agent 8.32.0 and openvox-server 8.18.0, replacing the vendored gem with 1.19.1 using the component's install steps:
I did not build the runtime locally. This needs a runtime release and a promotion into openvox 8.x before a fixed agent ships. The regression test for the openvox acceptance suite is OpenVoxProject/openvox#773.
Assisted by Claude.