Skip to content

Hold multi_json at 1.19.1 in agent-runtime-8.x - #334

Merged
nmburgan merged 1 commit into
OpenVoxProject:mainfrom
miharp:pin-multi-json-agent-runtime
Nov 5, 2026
Merged

nmburgan merged 1 commit into
OpenVoxProject:mainfrom
miharp:pin-multi-json-agent-runtime

Conversation

@miharp

@miharp miharp commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #333.

Since #288 the 8.x agent runtime ships multi_json 1.21.2 in the vendor gem directory that puppetserver also loads from. OpenVox Server 8 cannot load it, so require 'multi_json' fails on the server from openvox-agent 8.31.1 on. The issue has the details and a container repro.

Changes:

  • rubygem-multi_json.rb sets the version to 1.19.1 where ruby_version is 3.2. Only agent-runtime-8.x sets that. openbolt-runtime keeps following the latest release.
  • The override sits after the section update_gems maintains. The automation only rewrites lines inside that section, so it keeps updating the version there and leaves the override alone. In the issue I wrote that a per-project conditional would not survive a bot run. That only holds inside the maintained section.

Verified:

  • vanagon inspect <project> el-9-x86_64:

    project multi_json GEM_HOME
    agent-runtime-8.x 1.19.1 /opt/puppetlabs/puppet/lib/ruby/vendor_gems
    agent-runtime-main not shipped
    openbolt-runtime 1.21.2 /opt/puppetlabs/bolt/lib/ruby/gems/4.0.0
  • rake vox:update_gems_wo_commit with the maintained version set back to 1.21.1: it rewrote the section to 1.21.2 and did not touch the override.

  • A container with openvox-agent 8.32.0 and openvox-server 8.18.0, replacing the vendored gem with 1.19.1 using the component's install steps:

    --- before: multi_json-1.21.2
    --- after: multi_json-1.19.1
    --- puppetserver JRuby:
    1.19.1
    {"ok"=>true}
    --- agent MRI:
    3.2.11
    1.19.1
    {"ok"=>true}
    

I did not build the runtime locally. This needs a runtime release and a promotion into openvox 8.x before a fixed agent ships. The regression test for the openvox acceptance suite is OpenVoxProject/openvox#773.

Assisted by Claude.

@miharp

miharp commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Acceptance test for #333: OpenVoxProject/openvox#773

I ran it on my fork against the released openvox8 packages (agent 8.32.0, server 8.18.0), which carry the unpinned gem: https://github.com/miharp/openvox/actions/runs/42023349579

  • All 11 shard:group2 jobs fail, one per OS, with the new test as the only errored case. It hits the multi_json LoadError from the issue.
  • The other 48 jobs pass.

The test should go green once a runtime with this change is promoted into openvox 8.x.

@nmburgan

nmburgan commented Nov 5, 2026

Copy link
Copy Markdown
Member

I think the TL;DR is that multi_json 1.20 bumped the min Ruby version to 3.2, and JRuby 9.4 is technically MRI 3.1 compatible, yes?

agent-runtime-8.x installs multi_json into the vendor gem directory that
puppetserver also loads from. Since OpenVoxProject#288 that has been 1.21.2, which
OpenVox Server 8 cannot load. The ruby platform gem has no JRuby options
cache backend, and 1.20.0 and later need Ruby 3.2 while the server runs
JRuby 9.4 (Ruby 3.1). From openvox-agent 8.31.1 on, `require 'multi_json'`
fails on the server with a LoadError.

Override the version where ruby_version is 3.2, after the section
update_gems maintains. The automation keeps other projects on the
latest release and does not touch the override.

Fixes OpenVoxProject#333

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Michael Harp <mike@mikeharp.com>
@miharp
miharp force-pushed the pin-multi-json-agent-runtime branch from 49bb038 to c8088f4 Compare November 5, 2026 20:03
@miharp miharp changed the title Hold multi_json at 1.19.1 in the agent runtimes Hold multi_json at 1.19.1 in agent-runtime-8.x Nov 5, 2026
@miharp

miharp commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Half of it. 1.20 did raise the minimum to Ruby 3.2, and JRuby 9.4 is 3.1. The LoadError in #333 is the other half: 1.20 also split into ruby and java platform gems, and the ruby one we install has no options_cache/concurrent_store.rb, which the gem requires when RUBY_ENGINE is jruby.

Switched to the ruby_version check and rebased, thanks. vanagon inspect still resolves 1.19.1 for agent-runtime-8.x and 1.21.2 for openbolt-runtime.

@nmburgan
nmburgan merged commit b48191f into OpenVoxProject:main Nov 5, 2026
137 of 139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: openvox-agent 8.31.1+ ships a multi_json that OpenVox Server 8 cannot load (regression of #156)

2 participants