Repository navigation
Conversation
The agent installs multi_json into the vendor gem directory that puppetserver also loads from. A puppet-runtime gem update has twice shipped a version that puppetserver's JRuby cannot load (puppet-runtime#156, puppet-runtime#333), and nothing in the acceptance suite noticed, because OpenVox itself no longer requires the gem. Require it through `puppetserver ruby` on the master, next to the r10k test that covers the same class of problem. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Michael Harp <mike@mikeharp.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent installs multi_json into the vendor gem directory that puppetserver also loads from. puppet-runtime has twice shipped a version that puppetserver's JRuby cannot load (OpenVoxProject/puppet-runtime#156, OpenVoxProject/puppet-runtime#333). The acceptance suite did not notice, because OpenVox itself stopped requiring the gem in 8.25.0.
This adds a test that requires the gem through
puppetserver rubyon the master. It sits next tor10k.rb, which covers the same class of problem.It targets 8.x directly.
agent-runtime-maindoes not ship multi_json, so there is nothing to check on main.The test fails until a runtime with OpenVoxProject/puppet-runtime#334 is promoted into 8.x. I ran the acceptance workflow on my fork against the released openvox8 packages (agent 8.32.0, server 8.18.0): https://github.com/miharp/openvox/actions/runs/42023349579
shard:group2jobs fail, one per OS. In each, this test is the only errored case and nothing else fails.The same command in a container, before and after swapping the vendored gem to the 1.19.1 that OpenVoxProject/puppet-runtime#334 pins:
Assisted by Claude.