Repository navigation
Fix the checks the 1.1.0 release PR failed - #539
Merged
Merged
Conversation
…erifiers Since the X11 resources are deferred, platform_wrapper.mouse is a proxy object with no __name__, so the FreeBSD and X11 verifiers failed on a backend they had in fact selected. They now ask the proxy's module which backend it chose.
The informational classification step still caught main's PortalConsentNotGranted, which the development line's oeffis does not define, and the AttributeError ended the whole portal job.
PySide6 6.11.2 types loadFromData's format as bytes, 6.12.0 also accepts str, and the runtime takes only str: no spelling satisfied both stubs in the typing-extras job. The JPEG header identifies the image anyway.
The container image has PySide6 but no libEGL, so importing QtWidgets
fails; importorskip("PySide6") let these four modules error at
collection instead of skipping like the rest of the GUI tests.
- Fixture threads raise or record a mismatch instead of asserting inside the handler that forwards every failure to the parent test. - The Android helper declares cleartext traffic off and shrinks its release build with R8, keeping the instrumentation it is started by. - The workspace example's private value is no longer called a password. - The loopback server base, the CI tooling's own path arguments, its 0600 temp file and the seeded fixture generator are marked as reviewed, each with its reason.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
A request is capped at 0.25 s, and on the Quality workflow's Ubuntu runners the observer sometimes had not polled within it, so the helper's first acquire raised 'deadline exhausted' and the test failed before reaching what it checks. A timed-out request allocates no lease, so the helper now retries it like a busy source, within five seconds.
SonarCloud flags the helper build because its dependency versions are not pinned by a lock file. Every configuration is now locked; while no gradle.lockfile exists Gradle resolves as before. A temporary step in the instrumentation job writes the lock files with --write-locks and keeps them as an artifact, so the real files can be committed and the step removed.
The checks resolved the wrapper module from the proxy's __module__ with importlib, which static analysis reads as importing arbitrary code. The wrapper is always _platform_linux, so it is imported directly and the proxy is checked to be its _Mouse.
|
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release PR (#538,
dev→main) runs workflows that never run ondev. Some of them failed on the merged tree. This fixes those failures.Failures fixed
platform_wrapper.mouseis a proxy with no__name__. The verifiers now ask the proxy's module which backend it selected.PortalConsentNotGranted, which dev'soeffisdoes not define. It now readsOeffisUnavailable's structuredstate.QPixmap.loadFromData's format argument is typedbytesin 6.11.2, while the runtime only acceptsstr. The call now passes no format; the JPEG header identifies the image.libEGL, and four agent GUI test modules errored at collection. They now skip whenQtWidgetscannot be imported, like the other GUI tests.assertinside a handler that catchesAssertionError.password;NOSONARand a reason: the loopback server base, the CI tooling's own path arguments, its 0600 temp file, and the seeded fixture generator.Gradle lock files and test flakes
native/android_helpernow locks every dependency configuration. A temporary step in the android-helper workflow writes the lock files with--write-locksand keeps them as an artifact. That workflow runs on the push todevafter this merges. A follow-up PR commits the files and removes the step.