Repository navigation
Skip the agent GUI tests when Qt cannot load - #541
Merged
Merged
Conversation
…sent
The container image has PySide6 but no libEGL, so QtWidgets fails to
import. These 13 modules guarded with importorskip("PySide6"), which
succeeds there, and their tests failed with ImportError instead of
skipping like the rest of the GUI suite.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
The test gave the task a 2 s wall budget and expects it to run out while the helper's fourth observation sleeps. On the release PR's Windows 3.10 runner the helper start and the first observe/act alone took longer, so the budget ran out during setup instead. The budget is now 6 s under a 20 s action limit: enough for setup, and still spent during the 30 s sleep.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release PR #538 runs the headless suite inside the container image. That image has PySide6 installed but no
libEGL, soPySide6.QtWidgetsfails to import.#539 fixed the four modules that errored at collection. Once those four were fixed, the run reached 13 more modules, and each failed with
ImportError: libEGL.so.1: they guard withpytest.importorskip("PySide6"), which succeeds in the image.All 14 bare guards in the test tree now use
pytest.importorskip("PySide6.QtWidgets", exc_type=ImportError), as the rest of the GUI suite does. Where Qt loads, the tests still run: the 13 modules pass locally (51 tests).Also included: a timing fix for the grounding wall-deadline test.
test_wall_deadline_during_grounding_retires_before_input_cleanupfailed on this PR's Windows 3.10 runner withtask wall budget exhausted.