Skip to content

build(deps): bump @exadev/eslint-config to 3.0.0 - #68

Merged
Mearman merged 4 commits into
mainfrom
chore/eslint-config-3
Oct 10, 2026
Merged

Mearman merged 4 commits into
mainfrom
chore/eslint-config-3

Conversation

@Mearman

@Mearman Mearman commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

Bumps @exadev/eslint-config from 2.12.1 to 3.0.0 in the root and all three packages. No runtime code, behaviour or published API changes.

3.0.0 makes exadevConfig take its options object alone, so each of the four eslint.config.ts files now spreads exadevConfig() inside defineConfig and lists its own blocks after it. The consistent-type-imports override has a files glob because the shared config's plugins are now scoped to file globs.

Going from 2.12.1 also pulls in the rules added across the 2.x line. What they flag is handled in the commits before the bump, each of which passes lint, typecheck and the unit tests on its own: JSON key order, test files renamed with a unit, integration or e2e suffix (vitest globs and turbo inputs updated), and statement padding and comment placement.

The few declarations that must keep their shape are exempted from the rule that flags them by files-scoped overrides in the package configs, each with its reason: the published count signature, the evaluator's positional parameters on the hot path, the async driver's sequential awaits, and the SQL fixtures' sequential seeding.

Refs ExaDev/eslint-config#129

Package manifests, tsconfig files, the Turborepo pipeline and the wrangler config list their keys
in alphanumeric order, so a key's position is predictable and a new one has an obvious place.
Source tests carry a `unit` suffix before `.test`, the suites under `test/integration` an
`integration` suffix, and the built-package smoke and declaration checks and the workerd suite an
`e2e` suffix. The vitest project globs and turbo inputs that name individual files follow the
renames.
…rules require

Blank lines separate statements, trailing line comments sit above the code they describe,
multi-line comments take the doc-comment form, class members are separated, and exported helpers
declare their return types.
`exadevConfig` takes its options alone in 3.0.0, so each config spreads its result inside
`defineConfig` and lists its own blocks after it. The `consistent-type-imports` overrides declare
the TypeScript globs they apply to, since the shared config's plugins are scoped to file globs.

Declarations that must keep their released shape (the published `count` signature, the evaluator's
positional parameters, the async driver's sequential awaits and the fixtures' sequential seeding)
are exempted from the rule that now flags them by a files-scoped override stating why.
@Mearman
Mearman force-pushed the chore/eslint-config-3 branch from 5be512e to d27d58e Compare October 10, 2026 08:28
@Mearman
Mearman marked this pull request as ready for review October 10, 2026 08:33
@Mearman

Mearman commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-10T08:38:42.522842Z d27d58e Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: d27d58e5e1

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@Mearman
Mearman merged commit 26722f6 into main Oct 10, 2026
14 checks passed
@Mearman
Mearman deleted the chore/eslint-config-3 branch October 10, 2026 08:52
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in trilean-regex@1.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in trilean@1.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in trilean-sql@2.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant