Repository navigation
add pointing-based selection among multiple confluence points in vertex reconstruction - #182
Merged
francois-drielsma merged 2 commits intoOct 19, 2026
Conversation
francois-drielsma
approved these changes
Oct 19, 2026
francois-drielsma
left a comment
Member
There was a problem hiding this comment.
Looks good. Added regression coverage for shower-driven selection and unchanged default/fallback paths, plus formatting fixes. All 17 vertex tests and pre-commit checks pass.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
- Coverage 99.99% 99.99% -0.01%
==========================================
Files 435 440 +5
Lines 37678 39316 +1638
==========================================
+ Hits 37677 39314 +1637
- Misses 1 2 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an optional
confluence_selectionflag to the vertex post-processor. Off by default, so nothing changes unless it's turned on.When
get_confluence_pointsfinds more than one confluence group,get_vertexcurrently goes toconfluence_dirand then usually ends up intrack_length(start of the longest track). Withconfluence_selection: pointing, each candidate is instead scored by how well the particles point away from it, and the best one is taken. A particle starting withintouching_thresholdof the candidate counts as 1, otherwise(1 + cos θ)/2, whereθis the angle between its direction and the candidate --> start vector. No beam direction is used, so it should also work for atmospherics.Usage -->

Motivation
On the DUNE FD-HD LBNF v1 sample, about 38% of CC events have more than one confluence group. These mostly end up in
track_length, which accounts for over half of the vertices that are >10 cm off.Full inference on the same 10k events with/without the flag, CC (numu + nue), overlap > 0.5 (almost 5.3k interactions):
About 1.6k interactions change vertex, roughly 1.3k of them for the better.
Type of change
Testing
New unit tests for the selection and for the processor passing the flag through. Existing vertex tests still pass. Plus the two inference runs above.
Notes