Skip to content

Warn users of the bundle script when they accidentally provide extra arguments #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bieryAtFnal merged 3 commits into from
Oct 14, 2026
Merged

Warn users of the bundle script when they accidentally provide extra arguments #360

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3641645
Added a check for unexpected arguments to dunedaq_integtest_bundle.sh…
Sep 23, 2026
d02dc0c
Merge remote-tracking branch 'origin/develop' into kbiery/bundle_scri…
Oct 13, 2026
e94d4e7
Merge remote-tracking branch 'origin/develop' into kbiery/bundle_scri…
Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions scripts/dunedaq_integtest_bundle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,15 @@ invalid_numeric_option_value() {
echo ""
}

# function to report one or more unexpected command-line arguments
unexpected_command_arguments() {
declare -r script_name=$(basename "$0")
echo ""
echo -e "\U0001F534 ERROR: ${script_name} received unexpected command-line argument(s): $@"
echo ">>> Reminder: running '${script_name} --help' will list the supported options"
echo ""
}

# function to check for a specific string in a list
string_in_list() {
# get the search string from the first argument
Expand Down Expand Up @@ -331,6 +340,13 @@ while true; do
esac
done

# if any command-line arguments remain after all of the 'getopt' processing, that is
# a problem (since we don't expect any), so we let the user know.
if [ $# -ne 0 ]; then
unexpected_command_arguments "$@"
exit 1
fi

# assemble the basic elements for the pytest command that we will use
if [[ "${#PYTEST_OPTIONS[@]}" -gt 0 ]]; then
PYTEST_BASE_COMMAND+=("${PYTEST_OPTIONS[@]}" "--") # Add the requested options to the pytest command
Expand Down
Loading