Skip to content

Warn users of the bundle script when they accidentally provide extra arguments - #360

Merged
bieryAtFnal merged 3 commits into
developfrom
kbiery/bundle_script_no_extra_args
Oct 14, 2026
Merged

bieryAtFnal merged 3 commits into
developfrom
kbiery/bundle_script_no_extra_args

Conversation

@bieryAtFnal

Copy link
Copy Markdown
Collaborator

Description

Recently, I noticed that when I mis-type the arguments to the dunedaq_integtest_bundle.sh script, it doesn't let me know about my mistake.

For example:

dunedaq_integtest_bundle.sh random 5 -r all --list

The changes in this PR provide an error message when extra command-line arguments are provided.

To test this, we can run the sample command shown above with and without these changes.

Here is a sample error message:

🔴 ERROR: dunedaq_integtest_bundle.sh received unexpected command-line argument(s): random 5
>>> Reminder: running 'dunedaq_integtest_bundle.sh --help' will list the supported options

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing checklist

  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas

@andrewmogan andrewmogan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. I also experimented with moving the extra argument around, still with the correct result:

dunedaq_integtest_bundle.sh -r local -x min -k tpg --stop-on-failure asdf
dunedaq_integtest_bundle.sh -r local asdf -x min -k tpg --stop-on-failure

Code changes look reasonable. Approved.

@bieryAtFnal
bieryAtFnal merged commit 2ef615a into develop Oct 14, 2026
3 of 4 checks passed
@bieryAtFnal
bieryAtFnal deleted the kbiery/bundle_script_no_extra_args branch October 14, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants