Skip to content

Fix duplicate crafting job dependencies when interfaces re-register #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubensworks merged 1 commit into from
Oct 14, 2026
Merged

Fix duplicate crafting job dependencies when interfaces re-register #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/main/java/org/cyclops/integratedcrafting/api/crafting/CraftingJobDependencyGraph.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,20 @@ public void addDependency(CraftingJob craftingJob, int dependency) {
jobDependencies = new IntArrayList();
dependencies.put(craftingJob.getId(), jobDependencies);
}
jobDependencies.add(dependency);
// An edge is only stored once, as crafting interfaces add the edges of their jobs again when they re-register
if (!jobDependencies.contains(dependency)) {
jobDependencies.add(dependency);
}

// Save reverse link
IntCollection jobDependents = dependents.get(dependency);
if (jobDependents == null) {
jobDependents = new IntArrayList();
dependents.put(dependency, jobDependents);
}
jobDependents.add(craftingJob.getId());
if (!jobDependents.contains(craftingJob.getId())) {
jobDependents.add(craftingJob.getId());
}
}

public void removeDependency(int craftingJob, int dependency) {
Expand Down
17 changes: 17 additions & 0 deletions ...test/java/org/cyclops/integratedcrafting/api/crafting/TestCraftingJobDependencyGraph.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,23 @@ public void testSingleDependencyDouble() {
assertThat(Sets.newHashSet(g.getDependents(J1)), equalTo(Sets.newHashSet(J0)));
}

@Test
public void testSingleDependencyDoubleStoredOnce() {
g.addDependency(J0, J1);
g.addDependency(J0, J1.getId());
assertThat(Lists.newArrayList(g.getDependencies(J0)), equalTo(Lists.newArrayList(J1)));
assertThat(Lists.newArrayList(g.getDependents(J1)), equalTo(Lists.newArrayList(J0)));
}

@Test
public void testSingleDependencyDoubleRemove() {
g.addDependency(J0, J1);
g.addDependency(J0, J1);
g.removeDependency(0, 1);
assertThat(Sets.newHashSet(g.getCraftingJobs()), equalTo(Sets.newHashSet()));
assertThat(g.hasDependencies(J0), equalTo(false));
}

@Test
public void testSingleDependencyRemove() {
g.addDependency(J0, J1);
Expand Down
Loading