Repository navigation
fix: update s on ZMQ reads in Julia so unchanged() works - #629
Open
bhuvan-somisetty wants to merge 2 commits into
Open
bhuvan-somisetty wants to merge 2 commits into
bhuvan-somisetty wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #628
_zmq_read()in concore.jl and concoredocker.jl now adds the received message tos, same as file reads and concore.py, sounchanged()returns false after a ZMQ read.Added a live PAIR test for both. They fail on dev and pass with this change. CI doesn't install ZMQ.jl so they get skipped there, I ran them locally with ZMQ.jl 1.5.1. Full Julia suite passes with and without ZMQ.jl.
Also moved the comma params test in TestConcoreHpp.cpp from
in/1/toin1/. It came in from another branch after #621 and was failing the C++ jobs on dev.