Repository navigation
feat(applications): standalone application shell with its own menu - #52
Open
rubenvdlinde wants to merge 1 commit into
Open
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
An application opened on its own, at /apps/tables/app/{id}, shows its menu as
the navigation and starts on its first menu item. A menu item route opens the
start page, a grid page, or a table or view; inside Tables it sits below a
breadcrumb back to the application. The start page keeps its own entry when no
menu item opens it.
Assisted-by: ClaudeCode:claude-opus-5-5
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild of #39 (originally #25) on the page model of nextcloud#3100 / nextcloud#3099 (#46-#51), see #13. Stacked on
stack-5-main(the page stack #46-#51 with the menu stack #20-#23 merged in; the dashboard menu item and the start page share the technical namedashboard).What changes
An application opened on its own, at
/apps/tables/app/{id}, gets its own navigation: its menu replaces the Tables navigation, and every menu item opens inside the application.ApplicationNavigation: the application's icon, name and description, then its menu, nested one level like the stored menu. A link opens outside the app. The owner gets "Configure in Tables"./application/{id}/menu/{technicalName}: apageitem opens that page; the dashboard item opens the start page with its widgets and its tables and views, any other page opens as a grid page. Aviewortableitem shows its rows (DataWidget, the component of a data widget). An unknown or broken item shows an empty state.MenuItemIcon: a warning icon for a broken item, else the chosen icon, else one for what the item opens.What changed because of nextcloud#3100 / nextcloud#3099
page_content) and shows its widgets above them (feat(pages): widgets on the application start page (step 6, separable)聽#51), so the dashboard item renders exactly that, the same as the start page inside Tables./application/{id}.pages(title, emoji, page type from feat(pages): store grid pages and their widgets relationally (#3100, step 1)聽#46) instead of a separate page list.Tests
Nextcloud 34 container (PostgreSQL 16), Playwright at 1600 x 1000,
--timeout=120000:playwright/e2e/application.spec.ts(ported from feat(applications): standalone application shell with its own menu聽#39): opened on its own, the menu shows 4 items and starts on/menu/dashboardwith the start page's header widget and table and no page bar; a page item opens its grid page; a table item its rows; a link keeps its URL; no focus on load. Inside Tables the breadcrumb and "Open application". A page item whose page was deleted shows the warning icon and the empty state. Without a dashboard item the start page gets its own entry.4 passed (27.9s).context-grid-pages.spec.ts,context-menu.spec.ts,context.spec.ts,context-navigation.spec.ts:17 passed (6.5m).env -u ELECTRON_RUN_AS_NODE npx cypress run --component --spec cypress/component/menuItems.cy.js:All specs passed! 15 15(menu routes, menu tree).npm run lint: 0 errors, 1 inherited warning (src/store/store.js:176);npm run stylelint: clean;npm run build: OK.stack-5-mainitself: whole unit suiteOK (517 tests, 1077 assertions),composer cs:checkno files, psalmNo errors found!.Inherited: the create endpoint answers with
pages[].pageTypewhile the read endpoint usespage_type; the spec reads the start page id from the dashboard menu item.Prepared in the Conduction fork for porting upstream by @remko48. Prepared with Claude Code.