Repository navigation
feat(applications): standalone application shell with its own menu - #39
Open
rubenvdlinde wants to merge 2 commits into
Open
rubenvdlinde wants to merge 2 commits into
rubenvdlinde wants to merge 2 commits into
Conversation
An application opened on its own, at /apps/tables/app/{id}, gets its own
navigation: its menu replaces the Tables navigation, and every menu item
opens inside the application. A page item opens that page of the
application on the grid, the dashboard item the start page; a view or
table item shows its rows; a link opens outside. A broken item shows a
warning icon and an empty state. Opened on its own, the application
starts on its first menu item that is not a link; when no item opens the
start page, the start page gets an entry of its own.
Inside Tables, /application/{id}/menu/{technicalName} shows the item
below a breadcrumb back to the application, with a button that opens the
application on its own. The content area only takes focus after a first
click or key press.
Assisted-by: ClaudeCode:claude-opus-5-5
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild of #25 on application pages (nextcloud#3075, see #13 and the reply on nextcloud#3075). Stacked on
stack-4-main(page stack #35-#38 with the menu stack #20-#23 merged in).What changes
An application opened on its own, at
/apps/tables/app/{id}, gets its own navigation: its menu replaces the Tables navigation, and every menu item opens inside the application.ApplicationNavigation: the application's icon, name and description, then its menu, nested one level like the stored menu. A link opens outside the app. The owner gets "Configure in Tables"./application/{id}/menu/{technicalName}: apageitem opens that page of the application on the grid (GridPage, the dashboard item opens the start page), aviewortableitem shows its rows (DataWidget, the same component as a data widget), an unknown or broken item shows an empty state.MenuItemIcon: a warning icon for a broken item, else the chosen icon, else one for what the item opens.Carried over from #25, and what changed because of pages
App.vue(shell switch, focus),ApplicationNavigation,MenuItemIcon,menuItemRoute/menuTree, the route, the breadcrumb.pagetargets render the application page from the page API,view/tabletargets reuseDataWidgetinstead of a copy of the old start page loading code inContext.vue.Tests
Nextcloud 34 container (PostgreSQL 16), Playwright at 1600 x 1000:
playwright/e2e/application.spec.ts(new): opened on its own, the menu shows 4 items, starts on/menu/dashboardwith the start page's table, a page item opens its grid page, a table item its rows, a link keeps its URL, no focus on load; inside Tables the breadcrumb and "Open application"; a page item whose page was deleted shows the warning icon and the empty state; without a dashboard item the start page gets its own entry.4 passed.context-grid-pages.spec.ts,context-menu.spec.ts,context-navigation.spec.ts,context.spec.ts:13 passed(run with--timeout=120000, the CI value; the local instance is slow).npx cypress run --component --spec cypress/component/menuItems.cy.js:14 passing(page, view and table routes, menu tree).npm run lint: 0 errors (1 inherited warning instore.js),npm run stylelintclean,npm run buildOK.Inherited: the create endpoint answers with
pages[].pageType(entity serialisation) while the read endpoint usespage_type; the test reads the start page id from the dashboard menu item instead.Prepared in the Conduction fork for porting upstream by @remko48. Prepared with Claude Code.