Repository navigation
feat(pages): grid pages in the application UI (#3099, step 4) - #49
Open
rubenvdlinde wants to merge 1 commit into
Open
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Adds the page bar under the application description (start page, one tab per grid page, "Add page" for managers), a route per grid page, the add and edit page dialog (title, emoji, description) and the grid page with an edit mode: drag, resize, configure and remove widgets, Save stores the whole layout, Cancel drops it. People who cannot manage the application see the pages read-only with live data. The start page is unchanged. Assisted-by: ClaudeCode:claude-opus-5-5
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 4 of the page rework on nextcloud#3099 / nextcloud#3100 (follows the review on nextcloud#3075). Stacked on #48.
What
/application/:contextId/page/:pageIdshowing the grid page: emoji, title and description, then the grid.nextcloud#3099 points covered
Page bar, grid page, edit mode with Save/Cancel, widget types dialog, own-tables-only data widget, add page dialog, read-only sharee, "Only people who manage the application can add, edit or delete pages", "If a table or view leaves the application, its widget stays on the page and asks the editor to pick another one".
Tests (Nextcloud 34 on :8194, viewport 1600 px,
--timeout=120000)npx playwright test playwright/e2e/context-grid-pages.spec.ts:5 passed (58.2s): start page unchanged with the page bar; create a page, add a header and a data widget for an application table (the table outside the application is not offered), save, reload; Cancel sends no PATCH; read-only sharee sees live data, no edit controls, PATCH answers 403; a table removed from the application leaves the widget with "No table or view to show" and, in edit mode, "Pick a table or view".context.spec.ts+context-navigation.spec.ts:8 passed (5.0m).All specs passed! 14 14.npm run lint: 0 errors, 1 inherited warning (src/store/store.js:176);npm run stylelint: clean.Known limit: the UI shows the edit controls to the owner of the application (same rule as "Edit application" in the navigation). A sharee with manage permission can use the API but does not see the controls, because the context response does not carry the viewer's share permissions.
Prepared in the Conduction fork for porting upstream by @remko48. Prepared with Claude Code.