Repository navigation
fix: no Data Protection warnings at startup - #40
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AddAuthentication registers Data Protection, which nothing uses (bearer tokens only). With no home directory (the Pi's service users) its defaults pick an in-memory key repository and log three warnings at every start. Declare the ephemeral provider instead. The first test couldn't reproduce the warnings (a test process has a home directory, so the defaults pick a file repository): it now pins the provider; stage's log is the behavioural check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 14, 2026
ThorSPB
added a commit
that referenced
this pull request
Oct 14, 2026
Closes #39 ## What - `appsettings.json`: `Microsoft.AspNetCore.DataProtection` at Error. Real failures still log; the three "keys in memory" warnings don't. The README's config row says why, and when to lower it again. - Removes #40's `UseEphemeralDataProtectionProvider()`, whose comment claimed it kept the startup log clean. - The test now checks the effective levels: Warning off and Error on for Data Protection, and Warning still on for another `Microsoft.AspNetCore` category. ## Why #40 didn't work `UseEphemeralDataProtectionProvider()` replaces only `IDataProtectionProvider`. Data Protection's startup service still builds `XmlKeyManager` and loads its key ring, and that's what warns: stage's log after 55247a3 still had all three (`EphemeralXmlRepository`, `XmlKeyManager`). #40's test only pinned the provider type, so it passed either way. ## Testing - CI. Without the setting, `Microsoft.AspNetCore` at Warning applies and the first assertion fails. - After deploy: stage's startup log must show no Data Protection lines. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
What
AddDataProtection().UseEphemeralDataProtectionProvider(). Data Protection comes withAddAuthenticationbut protects nothing here (bearer tokens only), so its keys are ephemeral on purpose, and the code now says so.IDataProtectionProvideris the ephemeral one.Testing
api.logafter this deploys: the three warnings must be gone.🤖 Generated with Claude Code