Repository navigation
fix: Data Protection logs from Error up (the #40 fix didn't work) - #41
Merged
Merged
Conversation
…start #40 registered the ephemeral provider, which only replaces IDataProtectionProvider: the startup key-ring load still builds the XML key manager, and that is what warns (stage log after 55247a3). Remove it (its comment claimed the opposite) and set the category to Error in appsettings.json, documented in the README. The test checks the effective levels, which differ with and without the setting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
What
appsettings.json:Microsoft.AspNetCore.DataProtectionat Error. Real failures still log; the three "keys in memory" warnings don't. The README's config row says why, and when to lower it again.UseEphemeralDataProtectionProvider(), whose comment claimed it kept the startup log clean.Microsoft.AspNetCorecategory.Why #40 didn't work
UseEphemeralDataProtectionProvider()replaces onlyIDataProtectionProvider. Data Protection's startup service still buildsXmlKeyManagerand loads its key ring, and that's what warns: stage's log after 55247a3 still had all three (EphemeralXmlRepository,XmlKeyManager). #40's test only pinned the provider type, so it passed either way.Testing
Microsoft.AspNetCoreat Warning applies and the first assertion fails.🤖 Generated with Claude Code