Skip to content

ci: run a wind-down on a throwaway vault - #344

Merged
hpmaxi merged 3 commits into
feedbackfrom
ci/343-wind-down-in-ci
Oct 27, 2026
Merged

hpmaxi merged 3 commits into
feedbackfrom
ci/343-wind-down-in-ci

Conversation

@hpmaxi

@hpmaxi hpmaxi commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #343

CI ran the harness happy path and guards on every pull request, but the wind-down suite added in #261 only ran by hand. The build job now builds the short-wind-down vault and runs that suite after the guards.

Changes

  • Build the vault with --features short_wind_down into target/short-wind-down, where the harness looks for it.
  • Run npm run test:wind-down -w scripts/harness on the local network. A failure keeps the harness report, as it does for the earlier suites.

Deviations

None.

Acceptance criteria

  • The build job builds the vault with --features short_wind_down into target/short-wind-down
  • The build job runs npm run test:wind-down -w scripts/harness with HARNESS_NETWORK=local, after the guards
  • A failing wind-down fails the job and keeps the harness report

Test plan

Automated tests

  1. CI on this pull request: the step "Run a wind-down on a throwaway vault on the local network" passes with 6 tests.

Manual verification

None.

Breaking changes

None.

Checklist

  • Self-reviewed my own diff
  • Tests added or updated (this runs an existing suite)
  • Docs updated (if applicable) (the README already shows how to run the suite)
  • No unrelated changes bundled in

Screenshots

None.

@hpmaxi
hpmaxi requested a review from luchobonatti October 26, 2026 14:56
@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
strata-vault-kit-app Ready Ready Preview Oct 26, 2026 10:57pm UTC

Request Review

@hpmaxi
hpmaxi changed the base branch from fix/332-check-token-swaps to feedback October 27, 2026 15:18
@hpmaxi
hpmaxi merged commit 6e5114b into feedback Oct 27, 2026
3 checks passed

This branch was successfully deployed

1 active deployment
Preview — 40df3c50 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants