Repository navigation
chore: merge feedback into main - #359
Draft
luchobonatti wants to merge 310 commits into
Draft
luchobonatti wants to merge 310 commits into
luchobonatti wants to merge 310 commits into
Conversation
The timelock, storage and bindings crates become strata-timelock, strata-storage and strata-bindings, so a path such as strata_timelock::DAY_DURATION names the kit's own code. The contract interfaces are unchanged.
Both manifests that use proptest now pin the version Cargo.lock already holds, like every other dependency.
In the kit's own entrypoints, caller is the account that signs and holder is the account whose request or position the call is about. When one account is both, the entrypoint takes holder and that account signs. The vault's deposit, redemption and request-view entrypoints take holder instead of from, caller or controller, and fund takes caller. legal_transfer and the compliance contract's own admin calls take caller instead of operator. OpenZeppelin trait methods keep their names. Argument order and types do not change. The harness and the docs follow the new names.
A short section states how the kit's code is named and written: the strata- crate prefix, caller and holder in entrypoints, named errors, separate functions instead of boolean switches, guards, doc comments, design notes and exact pins.
ci: check formatting, lints and dependencies
feat(oracle): anchor a proof reference to every attestation
…nst-branch-contracts
After the token's setup closes, token role grants, the manager revoke, the admin hand-over, Set the compliance contract and Set the identity verifier go through propose_change. Governance lists the token's pending changes with Apply and Cancel. Closes #305
Attest price asks for the proof hash and an optional proof URI and sends them as the oracle's NavInput. Cycle shows the latest proof, and reads use accepted_at. Closes #235
…nst-branch-contracts
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
feat(app): collect a proof reference when attesting
feat(app): run the share token's admin changes through its timelock
feat(app): run the vault's timelocked changes through the console
…ments feat(app): follow the renamed vault arguments
With a pinned tag, stellar-scaffold no longer sees the action's container as its local network, starts its own and redeploys, so the app is built against this branch's contracts and fails on the type errors the app stack fixes. Pin the image again once the app compiles against them.
feat(app): name the NAV pause and follow the oracle's bounds
The previous commit blamed the pin for the app build failure. That was wrong: the same tree without the pin fails the same way. The app does not compile against this branch's contracts yet, which the app stack fixes; the pin is unrelated.
…contracts ci: build the app against the contracts the branch deploys
docs: write the threat model
chore: run CI on protocol 30 and read its ledgers
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges
feedbackintomain: the reviewed work on the contracts, the harness and the docs. This pull request stays a draft untilmainis ready to take it.GitHub closes an issue from
Closes #Nonly when a pull request merges into the default branch. The pull requests below merged intofeedback, so their issues are listed here, each with the pull request that did the work. Issues whose pull requests are still open are listed apart.Open issues this closes
Waiting for their pull requests to merge into
feedbackListed now so each issue links to this pull request. A line moves up when its pull request merges.
Already closed by hand
These were closed when their pull requests merged into
feedback. They are listed so each one links to this pull request.Test plan
CI on this pull request builds and tests
feedback's head againstmain.