Repository navigation
Enable 9 validation scenes that pass with Babylon.js 9.29.0 - #1934
Merged
bkaradzic-microsoft merged 1 commit intoOct 14, 2026
Merged
bkaradzic-microsoft merged 1 commit into
bkaradzic-microsoft merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
bkaradzic-microsoft
force-pushed
the
shotgun-landing-support
branch
from
October 14, 2026 01:34
27f3f3c to
847520b
Compare
bkaradzic-microsoft
changed the title
Enable scenes that pass with the Babylon.js npm 9.29.0 packages that BabylonNative currently pins: - Chibi Rex (validated at the reference's hardware scaling level) - apply-all-post-processes (stable ~3% deterministic near-miss) - 7 OpenPBR analytic-light scenes The 7 OpenPBR reference images are replaced with the Babylon.js 9.29.0 versions; the existing images no longer match the 9.29.0 renderer output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60c2ec68-6de1-445d-9fc9-b699db737eae
bkaradzic-microsoft
force-pushed
the
shotgun-landing-support
branch
from
October 14, 2026 02:03
847520b to
57b7d52
Compare
bkaradzic-microsoft
changed the title
CedricGuillemet
approved these changes
Oct 14, 2026
bghgary
approved these changes
Oct 14, 2026
bkaradzic-microsoft
added a commit
that referenced
this pull request
Oct 15, 2026
The scheduled `BabylonNative Nightly CI` has failed since the 2026-10-14 run (14 validation scenes fail), and so does every manual run of it on PRs. ## Cause The pipeline builds Win32 with the default JavaScript engine, Chakra. #1934, #1936, #1938 and #1942 enabled ~40 validation scenes after Win32 validation moved to V8 (#1935), but the Chakra parser rejects the playground snippets of 14 of them: ``` Failed to evaluate playground snippet #M2H33B#0: SyntaxError: Syntax error Failed to evaluate playground snippet #CSCJO2#17: SyntaxError: Unexpected identifier after numeric literal Failed to evaluate playground snippet #22HT5Z#10: SyntaxError: Expected '(' ``` Affected: `Material Plugin`, `custom-handling-of-materials-for-render-target-pass`, 4x `computeMaxExtents`, `FrameGraph nrge clustered lights (simple)`, `Render target texture with clustered lights`, and 6 `Clustered Lighting` / `Sponza Clustered Lighting` scenes. PR CI never sees it because it validates on V8 only. It is not a Babylon.js nightly regression: the same 14 pass on V8 with the current `preview.babylonjs.com` bundles (checked locally), and the Win32 V8 sanitizer job passes 463/464 (the one failure was an unrelated timeout, fixed in #1943). ## Change Build the nightly with `-D NAPI_JAVASCRIPT_ENGINE=V8`, the same engine PR CI validates on. Chakra still builds and runs UnitTests in PR CI (`Win32_x64_D3D11`). The alternative is to keep Chakra here and add `excludedJavaScriptEngines: ["Chakra"]` (from #1941) to the 14 scenes. I couldn't run the Azure pipeline from here. Please queue it on this branch to confirm it goes green. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c658bb82-1999-4035-840f-54a1df553faf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables 9 more validation scenes that pass with the Babylon.js npm packages BabylonNative currently pins (9.29.0). No dependency, engine-default, native-code or JsRuntimeHost changes.
Newly enabled
replace; default errorRatio)errorRatio3.3)Reference images
The 7 OpenPBR reference images are replaced with the versions from Babylon.js tag
9.29.0(byte-identical blobs, also identical in 9.30.0). No other reference images change.Validation (Win32 x64 D3D11, default Chakra build, npm Babylon.js 9.29.0)
validation_native.jsrun, matching CI: ran=436 passed=436 failed=0.upstream/masterwith the same setup: ran=427 passed=427.Not included
The remaining shotgun scenes depend on Babylon.js changes that have not been released to npm yet, or on paired native changes (WebGL viewport as context state, straight-alpha Canvas gradients) that regress scenes with the current Babylon.js 9.29.0. Those will follow once the Babylon.js side is published.
Node material 1 was dropped after CI showed it is a near-miss on JSI/V8 (4.7% vs 4.65%) and Linux OpenGL (5.5%). Tightened per-scene errorRatio values were removed so these scenes use the default 2.5% (Linux OpenGL diffs are 0.25-0.72%).