Skip to content

Build the nightly Azure pipeline with V8 - #1946

Merged
bkaradzic-microsoft merged 1 commit into
BabylonJS:masterfrom
bkaradzic-microsoft:ci/nightly-use-v8
Oct 15, 2026
Merged

bkaradzic-microsoft merged 1 commit into
BabylonJS:masterfrom
bkaradzic-microsoft:ci/nightly-use-v8

Conversation

@bkaradzic-microsoft

Copy link
Copy Markdown
Member

The scheduled BabylonNative Nightly CI has failed since the 2026-10-14 run (14 validation scenes fail), and so does every manual run of it on PRs.

Cause

The pipeline builds Win32 with the default JavaScript engine, Chakra. #1934, #1936, #1938 and #1942 enabled ~40 validation scenes after Win32 validation moved to V8 (#1935), but the Chakra parser rejects the playground snippets of 14 of them:

Failed to evaluate playground snippet #M2H33B#0: SyntaxError: Syntax error
Failed to evaluate playground snippet #CSCJO2#17: SyntaxError: Unexpected identifier after numeric literal
Failed to evaluate playground snippet #22HT5Z#10: SyntaxError: Expected '('

Affected: Material Plugin, custom-handling-of-materials-for-render-target-pass, 4x computeMaxExtents, FrameGraph nrge clustered lights (simple), Render target texture with clustered lights, and 6 Clustered Lighting / Sponza Clustered Lighting scenes. PR CI never sees it because it validates on V8 only.

It is not a Babylon.js nightly regression: the same 14 pass on V8 with the current preview.babylonjs.com bundles (checked locally), and the Win32 V8 sanitizer job passes 463/464 (the one failure was an unrelated timeout, fixed in #1943).

Change

Build the nightly with -D NAPI_JAVASCRIPT_ENGINE=V8, the same engine PR CI validates on.

Chakra still builds and runs UnitTests in PR CI (Win32_x64_D3D11). The alternative is to keep Chakra here and add excludedJavaScriptEngines: ["Chakra"] (from #1941) to the 14 scenes.

I couldn't run the Azure pipeline from here. Please queue it on this branch to confirm it goes green.

The nightly Azure pipeline builds with the default Chakra engine, which
cannot parse the playground snippets of 14 validation scenes enabled
after Win32 validation moved to V8. Use V8 like PR CI.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c658bb82-1999-4035-840f-54a1df553faf
Copilot AI balanced review requested due to automatic review settings October 15, 2026 14:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The flag matches existing Win32 V8 CI configuration, with no identified defects; Azure execution remains unverified.

0 open findings

What changed in this PR

Aligns nightly Win32 validation with PR CI’s V8 engine to avoid Chakra parsing failures in enabled scenes.

Changes:

  • Adds -D NAPI_JAVASCRIPT_ENGINE=V8 to the nightly CMake configuration.
File Description
nightly.yml Selects V8 for the nightly Win32 build.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bkaradzic-microsoft
bkaradzic-microsoft enabled auto-merge (squash) October 15, 2026 14:35
@bkaradzic-microsoft
bkaradzic-microsoft merged commit 68806b6 into BabylonJS:master Oct 15, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants