Repository navigation
Build the nightly Azure pipeline with V8 - #1946
Merged
bkaradzic-microsoft merged 1 commit intoOct 15, 2026
Merged
Conversation
The nightly Azure pipeline builds with the default Chakra engine, which cannot parse the playground snippets of 14 validation scenes enabled after Win32 validation moved to V8. Use V8 like PR CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c658bb82-1999-4035-840f-54a1df553faf
CedricGuillemet
approved these changes
Oct 15, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The flag matches existing Win32 V8 CI configuration, with no identified defects; Azure execution remains unverified.
0 open findings
What changed in this PR
Aligns nightly Win32 validation with PR CI’s V8 engine to avoid Chakra parsing failures in enabled scenes.
Changes:
- Adds
-D NAPI_JAVASCRIPT_ENGINE=V8to the nightly CMake configuration.
| File | Description |
|---|---|
| nightly.yml | Selects V8 for the nightly Win32 build. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bkaradzic-microsoft
enabled auto-merge (squash)
October 15, 2026 14:35
bkaradzic-microsoft
disabled auto-merge
October 15, 2026 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled
BabylonNative Nightly CIhas failed since the 2026-10-14 run (14 validation scenes fail), and so does every manual run of it on PRs.Cause
The pipeline builds Win32 with the default JavaScript engine, Chakra. #1934, #1936, #1938 and #1942 enabled ~40 validation scenes after Win32 validation moved to V8 (#1935), but the Chakra parser rejects the playground snippets of 14 of them:
Affected:
Material Plugin,custom-handling-of-materials-for-render-target-pass, 4xcomputeMaxExtents,FrameGraph nrge clustered lights (simple),Render target texture with clustered lights, and 6Clustered Lighting/Sponza Clustered Lightingscenes. PR CI never sees it because it validates on V8 only.It is not a Babylon.js nightly regression: the same 14 pass on V8 with the current
preview.babylonjs.combundles (checked locally), and the Win32 V8 sanitizer job passes 463/464 (the one failure was an unrelated timeout, fixed in #1943).Change
Build the nightly with
-D NAPI_JAVASCRIPT_ENGINE=V8, the same engine PR CI validates on.Chakra still builds and runs UnitTests in PR CI (
Win32_x64_D3D11). The alternative is to keep Chakra here and addexcludedJavaScriptEngines: ["Chakra"](from #1941) to the 14 scenes.I couldn't run the Azure pipeline from here. Please queue it on this branch to confirm it goes green.