Repository navigation
Enable 56 validation scenes that now pass - #1933
Merged
bkaradzic-microsoft merged 1 commit intoOct 13, 2026
Merged
bkaradzic-microsoft merged 1 commit into
bkaradzic-microsoft merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The configuration changes are sound; only a non-blocking stale explanation remains.
1 open finding
What changed in this PR
Enables 60 validation scenes that now pass following #1926 while retaining nine order-dependent exclusions.
Changes:
- Re-enables 60 validation scenes.
- Updates exclusion reasons for nine sequential-run failures.
| File | Description |
|---|---|
Apps/Playground/Scripts/config.json |
Updates validation-scene exclusions and reasons. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bkaradzic-microsoft
force-pushed
the
enable-passing-validation-tests
branch
2 times, most recently
from
October 13, 2026 21:47
8de5493 to
4c6a776
Compare
bkaradzic-microsoft
changed the title
bghgary
approved these changes
Oct 13, 2026
Enable the excluded validation scenes that pass in a full sequential run after BabylonJS#1926. Only Apps/Playground/Scripts/config.json changes. 17 of them fail on Linux OpenGL CI (llvmpipe), so they get excludedGraphicsApis ["OpenGL"]. Draco and WebAssembly scenes that hang on JavaScriptCore and JSI stay excluded. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60c2ec68-6de1-445d-9fc9-b699db737eae
bkaradzic-microsoft
force-pushed
the
enable-passing-validation-tests
branch
from
October 13, 2026 22:28
4c6a776 to
4d6bb1d
Compare
bkaradzic-microsoft
changed the title
bkaradzic-microsoft
enabled auto-merge (squash)
October 13, 2026 23:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables 56 validation scenes that pass after #1926. Only
Apps/Playground/Scripts/config.jsonchanges.How they were picked
--include-excluded(Windows, D3D11, Release, Babylon.js 9.29 from npm), then re-ran the excluded scenes that passed twice more to confirm they pass every time.Scenes enabled everywhere except OpenGL (
excludedGraphicsApis: ["OpenGL"])LLVM ERROR: Cannot emit physreg copy instruction. Prepass SSAO scenes that are already enabled are OpenGL-excluded for the same reason.FrameBufferGL::resolveasserts inglDrawBuffers(the same bug as Screen Space Reflections 2).Still excluded, with updated reasons
createScenenever resolves on JavaScriptCore (Linux CI) and JSI (Win32 CI), even when run alone; they pass on Chakra, V8 and QuickJS. The harness can't exclude per JS engine, so they stay excluded. 147 and 202-206 also get theleak-cleanupworkaround, which fixes their order dependency in a full run.dragon.babylon.GLTF Serializer Rotation conversion, left-handedin a full run, and none of the existing workarounds fix it.Testing